Bug 66537 - Test how DOMTokenList methods react to too few arguments
Summary: Test how DOMTokenList methods react to too few arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66235
  Show dependency treegraph
 
Reported: 2011-08-18 22:07 PDT by Mark Pilgrim (Google)
Modified: 2011-10-06 10:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.18 KB, patch)
2011-08-18 22:09 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch for landing (9.00 KB, patch)
2011-10-06 09:38 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-08-18 22:07:26 PDT
DOMTokenList.item()
DOMTokenList.contains()
DOMTokenList.add()
DOMTokenList.remove()
DOMTokenList.toggle()
Comment 1 Mark Pilgrim (Google) 2011-08-18 22:09:09 PDT
Created attachment 104460 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-18 22:58:22 PDT
Comment on attachment 104460 [details]
Patch

Attachment 104460 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9435097

New failing tests:
fast/dom/HTMLElement/class-list-quirks.html
Comment 3 Adam Barth 2011-08-19 11:23:39 PDT
> fast/dom/HTMLElement/class-list-quirks.html

This probably uses the same JS files in quirks mode.
Comment 4 Adam Barth 2011-09-03 14:27:04 PDT
Mark, can you update this patch so that it passes all the tests?
Comment 5 Adam Barth 2011-10-06 09:38:02 PDT
Created attachment 109967 [details]
Patch for landing
Comment 6 WebKit Review Bot 2011-10-06 10:21:52 PDT
Comment on attachment 109967 [details]
Patch for landing

Clearing flags on attachment: 109967

Committed r96827: <http://trac.webkit.org/changeset/96827>
Comment 7 WebKit Review Bot 2011-10-06 10:21:56 PDT
All reviewed patches have been landed.  Closing bug.