Bug 66534 - Switch RenderBoxModelObject to to new layout types
Summary: Switch RenderBoxModelObject to to new layout types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency tree / graph
 
Reported: 2011-08-18 21:17 PDT by Emil A Eklund
Modified: 2011-08-19 13:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (37.50 KB, patch)
2011-08-18 21:38 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch for landing (37.25 KB, patch)
2011-08-19 12:00 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-08-18 21:17:35 PDT 
Convert RenderBoxModelObject to new layout abstraction.
Comment 1 Emil A Eklund 2011-08-18 21:38:06 PDT 
Created attachment 104456 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-18 22:10:28 PDT 
Comment on attachment 104456 [details]
Patch

Attachment 104456 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9436074

New failing tests:
fast/backgrounds/gradient-background-leakage.html
Comment 3 Eric Seidel (no email) 2011-08-19 00:57:32 PDT 
Comment on attachment 104456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104456&action=review

Otherwise looks OK.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:590
> -    FloatSize contextScale(static_cast<float>(ctm.xScale()), static_cast<float>(ctm.yScale()));
> +    FloatSize contextScale(static_cast<LayoutUnit>(ctm.xScale()), static_cast<LayoutUnit>(ctm.yScale()));

LayoutUnit is currently an int, no?
Comment 4 Emil A Eklund 2011-08-19 12:00:30 PDT 
Created attachment 104541 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-08-19 13:41:12 PDT 
Comment on attachment 104541 [details]
Patch for landing

Clearing flags on attachment: 104541

Committed r93435: <http://trac.webkit.org/changeset/93435>
Comment 6 WebKit Review Bot 2011-08-19 13:41:17 PDT 
All reviewed patches have been landed.  Closing bug.