Bug 66524 - Test how HTMLButtonElement.setCustomValidity reacts to too few arguments
Summary: Test how HTMLButtonElement.setCustomValidity reacts to too few arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
: 66525 66526 66528 (view as bug list)
Depends on:
Blocks: 66235
  Show dependency tree / graph
 
Reported: 2011-08-18 19:59 PDT by Mark Pilgrim (Google)
Modified: 2011-11-30 03:23 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2011-08-18 20:00 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (2.66 KB, patch)
2011-11-29 11:23 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-08-18 19:59:48 PDT 
Test how HTMLButtonElement.setCustomValidity reacts to too few arguments
Comment 1 Mark Pilgrim (Google) 2011-08-18 20:00:57 PDT 
Created attachment 104441 [details]
Patch
Comment 2 Kent Tamura 2011-08-18 22:29:01 PDT 
Existing setCustomValidity-related tests are in LayoutTests/fast/forms/.  Would you merge this, Bug 66525,  and Bug 66526 into one test, and move it to fast/forms/ please?
Comment 3 Adam Barth 2011-09-03 14:24:57 PDT 
Comment on attachment 104441 [details]
Patch

I agree with Darin.  Having a separate test for each of these functions is kind of overkill.  Can we combine them into one (or a few) tests that exercise groups of related APIs.  For example, it seems like all the setCustomValidity tests would be better combined into a single test.
Comment 4 Mark Pilgrim (Google) 2011-11-29 11:23:13 PST 
Created attachment 117006 [details]
Patch
Comment 5 Mark Pilgrim (Google) 2011-11-29 11:23:42 PST 
*** Bug 66528 has been marked as a duplicate of this bug. ***
Comment 6 Mark Pilgrim (Google) 2011-11-29 11:23:51 PST 
*** Bug 66526 has been marked as a duplicate of this bug. ***
Comment 7 Mark Pilgrim (Google) 2011-11-29 11:24:06 PST 
*** Bug 66525 has been marked as a duplicate of this bug. ***
Comment 8 Mark Pilgrim (Google) 2011-11-29 11:24:29 PST 
Reopening with fresh patch.
Comment 9 WebKit Review Bot 2011-11-30 03:23:07 PST 
Comment on attachment 117006 [details]
Patch

Clearing flags on attachment: 117006

Committed r101478: <http://trac.webkit.org/changeset/101478>
Comment 10 WebKit Review Bot 2011-11-30 03:23:13 PST 
All reviewed patches have been landed.  Closing bug.