Bug 66509 - [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation
Summary: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker imple...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dmitry Lomov
URL:
Keywords:
Depends on: 61016 75278 75332
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-18 16:21 PDT by Dmitry Lomov
Modified: 2011-12-28 18:54 PST (History)
9 users (show)

See Also:


Attachments
The fix (76.32 KB, patch)
2011-12-22 13:54 PST, Dmitry Lomov
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
DumpRenderTree fixed (80.56 KB, patch)
2011-12-22 15:45 PST, Dmitry Lomov
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
CR feedback (80.60 KB, patch)
2011-12-22 16:17 PST, Dmitry Lomov
no flags Details | Formatted Diff | Diff
CR feedback (80.76 KB, patch)
2011-12-22 16:27 PST, Dmitry Lomov
no flags Details | Formatted Diff | Diff
Reuploading the patch to use cq to commit. (76.62 KB, patch)
2011-12-28 15:30 PST, Dmitry Lomov
dslomov: commit-queue-
Details | Formatted Diff | Diff
Missing file (81.66 KB, patch)
2011-12-28 15:39 PST, Dmitry Lomov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lomov 2011-08-18 16:21:57 PDT
1. NewWebWorkerBase and NewWebWorkerCommonClient should be renamed to WebWorkerBase and WebWorkerCommonClient
2. Currently existing WebWorkerBase and WebWorkerCommonClient should be merged into resp. shared worker interface/implementation classes.
3. Resulting dead code should be removed
Comment 1 Dmitry Lomov 2011-12-22 13:54:37 PST
Created attachment 120377 [details]
The fix

The patch looks massive but conceptually it is very simple - see ChangeLog for an overview
Comment 2 WebKit Review Bot 2011-12-22 14:20:46 PST
Comment on attachment 120377 [details]
The fix

Attachment 120377 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10962039
Comment 3 WebKit Review Bot 2011-12-22 14:45:47 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 Dmitry Lomov 2011-12-22 15:45:14 PST
Created attachment 120395 [details]
DumpRenderTree fixed
Comment 5 Darin Fisher (:fishd, Google) 2011-12-22 15:53:52 PST
Comment on attachment 120395 [details]
DumpRenderTree fixed

WebKit API changes LGTM... probably should get levin / dimich / jianli to review the rest.
Comment 6 David Levin 2011-12-22 16:09:45 PST
Comment on attachment 120395 [details]
DumpRenderTree fixed

View in context: https://bugs.webkit.org/attachment.cgi?id=120395&action=review

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:45
> +

No need for blank line here.

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:55
> +

No need for blank line here. (Just sort all of these together.)

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:59
> +#include <wtf/MainThread.h>

<wtf/... should be after other header includes.

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:61
>  #include "WorkerDebuggerAgent.h"

Should be with the other #include's.

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:162
> +                                              PassOwnPtr<MessagePortChannelArray> channels)

indent off. (in many places in this file).
Comment 7 Dmitry Lomov 2011-12-22 16:17:53 PST
Created attachment 120402 [details]
CR feedback
Comment 8 Dmitry Lomov 2011-12-22 16:27:13 PST
Created attachment 120405 [details]
CR feedback
Comment 9 WebKit Review Bot 2011-12-23 02:59:18 PST
Comment on attachment 120405 [details]
CR feedback

Clearing flags on attachment: 120405

Committed r103619: <http://trac.webkit.org/changeset/103619>
Comment 10 WebKit Review Bot 2011-12-23 02:59:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Ryosuke Niwa 2011-12-23 22:45:51 PST
This broke Linux clang builds:

In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/AccessibilityController.cpp:34:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/AccessibilityController.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:33:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/DumpRenderTree.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.cpp:46:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/GamepadController.cpp:34:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/GamepadController.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/PlainTextController.cpp:35:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/PlainTextController.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/LayoutTestController.cpp:36:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/LayoutTestController.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestNavigationController.cpp:34:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/TestNavigationController.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.cpp:32:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShellGtk.cpp:32:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/TestShellGtk.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.cpp:32:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/WebPermissions.cpp:35:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/WebPermissions.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TextInputController.cpp:34:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/TextInputController.o] Error 1
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShellLinux.cpp:32:
In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43:
third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*);
                               ^
third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here
    virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; }
                       ^
1 error generated.
Comment 12 Ryosuke Niwa 2011-12-24 11:27:12 PST
Reopen the bug since the patch was rolled out in http://trac.webkit.org/changeset/103658 per IRC discussion with Dmitry.
Comment 13 Dmitry Lomov 2011-12-24 15:42:46 PST
(In reply to comment #12)
> Reopen the bug since the patch was rolled out in http://trac.webkit.org/changeset/103658 per IRC discussion with Dmitry.

Thanks Ryosuke, will fix and reland.
Comment 14 Dmitry Lomov 2011-12-28 15:30:27 PST
Created attachment 120702 [details]
Reuploading the patch to use cq to commit.

Will probably need to clobber builders
Comment 15 Dmitry Lomov 2011-12-28 15:39:22 PST
Created attachment 120704 [details]
Missing file
Comment 16 WebKit Review Bot 2011-12-28 16:01:16 PST
Comment on attachment 120704 [details]
Missing file

Clearing flags on attachment: 120704

Committed r103785: <http://trac.webkit.org/changeset/103785>
Comment 17 WebKit Review Bot 2011-12-28 16:01:22 PST
All reviewed patches have been landed.  Closing bug.
Comment 18 Dmitry Lomov 2011-12-28 17:15:07 PST
Patch broke build... Trying to figure out why...
Comment 19 Dmitry Lomov 2011-12-28 18:54:13 PST
Patch landed in http://trac.webkit.org/changeset/103789