Bug 66502 – Switch RenderBlock to to new layout types

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Convert RenderBlock to new layout abstraction.

[Emil A Eklund]

Created attachment 104403 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 104403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104403&action=review

> Source/WebCore/rendering/RenderBlock.cpp:1349
> +            repaintRect.intersect(LayoutRect(0, 0, width(), height()));

I'm surprised there isn't a size() function to use here.

> Source/WebCore/rendering/RenderBlock.h:823
> +    typedef PODInterval<int, FloatingObject*> FloatingObjectInterval;
> +    typedef PODIntervalTree<int, FloatingObject*> FloatingObjectTree;

?

[Emil A Eklund]

(In reply to comment #2)
> (From update of attachment 104403 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104403&action=review
> 
> > Source/WebCore/rendering/RenderBlock.cpp:1349
> > +            repaintRect.intersect(LayoutRect(0, 0, width(), height()));
> 
> I'm surprised there isn't a size() function to use here.

There is, rewrote it as LayoutRect(LayoutPoint(), size())

> 
> > Source/WebCore/rendering/RenderBlock.h:823
> > +    typedef PODInterval<int, FloatingObject*> FloatingObjectInterval;
> > +    typedef PODIntervalTree<int, FloatingObject*> FloatingObjectTree;

Argh, merge failure, reverted.

Thanks.

[Emil A Eklund]

Created attachment 104535 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 104535 [details]
Patch for landing

Clearing flags on attachment: 104535

Committed r93436: <http://trac.webkit.org/changeset/93436>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.