Bug 66499 - Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditingBoundary*
Summary: Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 14:40 PDT by Ryosuke Niwa
Modified: 2011-08-19 15:20 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.52 KB, patch)
2011-08-19 10:39 PDT, Van Lam
no flags Details | Formatted Diff | Diff
Revised patch (8.49 KB, patch)
2011-08-19 13:50 PDT, Van Lam
no flags Details | Formatted Diff | Diff
Revised patch (8.49 KB, patch)
2011-08-19 14:03 PDT, Van Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-08-18 14:40:27 PDT
The following member functions of VisiblePosition use the non-standard term edit*able* boundary.  We should rename these functions to use edit*ing* boundary for consistency.
VisiblePosition honorEditableBoundaryAtOrBefore(const VisiblePosition&) const;
VisiblePosition honorEditableBoundaryAtOrAfter(const VisiblePosition&) const;
Comment 1 Van Lam 2011-08-19 10:39:44 PDT
Created attachment 104524 [details]
Patch
Comment 2 Ryosuke Niwa 2011-08-19 10:47:11 PDT
Comment on attachment 104524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104524&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Nit: you should remove this line.
Comment 3 Van Lam 2011-08-19 13:50:59 PDT
Created attachment 104558 [details]
Revised patch

Removed the "no new tests" line from changelog.
Comment 4 Van Lam 2011-08-19 14:03:40 PDT
Created attachment 104561 [details]
Revised patch

Fixed changelog.
Comment 5 WebKit Review Bot 2011-08-19 15:20:32 PDT
Comment on attachment 104561 [details]
Revised patch

Clearing flags on attachment: 104561

Committed r93443: <http://trac.webkit.org/changeset/93443>
Comment 6 WebKit Review Bot 2011-08-19 15:20:37 PDT
All reviewed patches have been landed.  Closing bug.