Bug 66496 - [GTK] textInputController.doCommand is not implemented
Summary: [GTK] textInputController.doCommand is not implemented
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 13:48 PDT by Ryosuke Niwa
Modified: 2011-09-28 10:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.90 KB, patch)
2011-09-28 04:58 PDT, Kaustubh Atrawalkar
cshu: review+
Details | Formatted Diff | Diff
Updated Patch (6.82 KB, patch)
2011-09-28 09:33 PDT, Kaustubh Atrawalkar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-08-18 13:48:19 PDT
textInputController hasn't been implemented on GTK's DRT yet.
Comment 1 Ryosuke Niwa 2011-08-18 13:50:10 PDT
Due to this bug, the tests added by http://trac.webkit.org/changeset/93291 are failing. I'll add them to the skipped list for now.
Comment 2 Kaustubh Atrawalkar 2011-09-28 04:58:03 PDT
Created attachment 109003 [details]
Patch

Implementation for textInputController.doCommand
Comment 3 Kaustubh Atrawalkar 2011-09-28 05:38:34 PDT
Currently all the command from WebCore/editing/EditorCommand.cpp -> CommandMap  entries (http://www.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/editing/EditorCommand.cpp&type=cs&l=1407) are supported.
Comment 4 Chang Shu 2011-09-28 06:23:50 PDT
Comment on attachment 109003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109003&action=review

Actually, I plan to modify the password echo tests to use eventSender, if possible, instead of textInputController.doCommand so they can be widely accepted. But it's nice to have this supported on GTK anyway. thanks.

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:601
> +    return;

this return can be removed.

> LayoutTests/ChangeLog:3
> +        Removed skipped tests under textInputController.doCommand for Gtk Port.

I usually still put the title here and some brief comments below.

> LayoutTests/platform/gtk/Skipped:-1548
> -

It's surprising but true that doCommand is used only in the above tests and some mac-specific tests. :)
Comment 5 Kaustubh Atrawalkar 2011-09-28 09:33:46 PDT
Created attachment 109029 [details]
Updated Patch

Updated patch with Chang Shu's comments.
Comment 6 Kaustubh Atrawalkar 2011-09-28 09:35:08 PDT
> Actually, I plan to modify the password echo tests to use eventSender, if possible, instead of textInputController.doCommand so they can be widely accepted. But it's nice to have this supported on GTK anyway. thanks.
> 

Thanks for that comment :) Glad to implement it.

> > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:601
> > +    return;
> 
> this return can be removed.
> 

Done.
> > LayoutTests/ChangeLog:3
> > +        Removed skipped tests under textInputController.doCommand for Gtk Port.
> 
> I usually still put the title here and some brief comments below.
> 

Updated the changeLog.
Comment 7 Kaustubh Atrawalkar 2011-09-28 09:47:45 PDT
Thanks for the review Martin :)
Comment 8 WebKit Review Bot 2011-09-28 10:39:20 PDT
Comment on attachment 109029 [details]
Updated Patch

Clearing flags on attachment: 109029

Committed r96234: <http://trac.webkit.org/changeset/96234>
Comment 9 WebKit Review Bot 2011-09-28 10:39:24 PDT
All reviewed patches have been landed.  Closing bug.