textInputController hasn't been implemented on GTK's DRT yet.
Due to this bug, the tests added by http://trac.webkit.org/changeset/93291 are failing. I'll add them to the skipped list for now.
Created attachment 109003 [details] Patch Implementation for textInputController.doCommand
Currently all the command from WebCore/editing/EditorCommand.cpp -> CommandMap entries (http://www.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/editing/EditorCommand.cpp&type=cs&l=1407) are supported.
Comment on attachment 109003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109003&action=review Actually, I plan to modify the password echo tests to use eventSender, if possible, instead of textInputController.doCommand so they can be widely accepted. But it's nice to have this supported on GTK anyway. thanks. > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:601 > + return; this return can be removed. > LayoutTests/ChangeLog:3 > + Removed skipped tests under textInputController.doCommand for Gtk Port. I usually still put the title here and some brief comments below. > LayoutTests/platform/gtk/Skipped:-1548 > - It's surprising but true that doCommand is used only in the above tests and some mac-specific tests. :)
Created attachment 109029 [details] Updated Patch Updated patch with Chang Shu's comments.
> Actually, I plan to modify the password echo tests to use eventSender, if possible, instead of textInputController.doCommand so they can be widely accepted. But it's nice to have this supported on GTK anyway. thanks. > Thanks for that comment :) Glad to implement it. > > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:601 > > + return; > > this return can be removed. > Done. > > LayoutTests/ChangeLog:3 > > + Removed skipped tests under textInputController.doCommand for Gtk Port. > > I usually still put the title here and some brief comments below. > Updated the changeLog.
Thanks for the review Martin :)
Comment on attachment 109029 [details] Updated Patch Clearing flags on attachment: 109029 Committed r96234: <http://trac.webkit.org/changeset/96234>
All reviewed patches have been landed. Closing bug.