RESOLVED FIXED 66495
Lion-specific scroller SPIs can use forward declaration instead of WebKitSystemInterface 
https://bugs.webkit.org/show_bug.cgi?id=66495
Summary Lion-specific scroller SPIs can use forward declaration instead of WebKitSyst...
Beth Dakin
Reported 2011-08-18 13:18:19 PDT
Title says it all. Lion-specific scroller SPIs can use forward declaration instead of WebKitSystemInterface. This will make code changes in this area simpler.
Attachments
Patch (41.46 KB, patch)
2011-08-18 13:24 PDT, Beth Dakin 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch which should build on Mac 10.6 (41.50 KB, patch)
2011-08-18 15:40 PDT, Beth Dakin 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch, another attempt at building on 10.6 (41.58 KB, patch)
2011-08-18 16:45 PDT, Beth Dakin 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2011-08-18 13:24:38 PDT
Created attachment 104389 [details] Patch
WebKit Review Bot
Comment 2 2011-08-18 14:21:14 PDT
Comment on attachment 104389 [details] Patch Attachment 104389 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9411013
Sam Weinig
Comment 3 2011-08-18 14:51:12 PDT
Comment on attachment 104389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104389&action=review > Source/WebCore/platform/mac/ScrollbarThemeMac.h:32 > +typedef id WKScrollbarPainterRef; This probably should have a more Objective-Cish name now.
Beth Dakin
Comment 4 2011-08-18 14:53:10 PDT
(In reply to comment #3) > (From update of attachment 104389 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104389&action=review > > > Source/WebCore/platform/mac/ScrollbarThemeMac.h:32 > > +typedef id WKScrollbarPainterRef; > > This probably should have a more Objective-Cish name now. I agree. The "WK" also doesn't make sense anymore. I thought I might make that change in a separate patch just to maintain maximal readability of the patch.
Beth Dakin
Comment 5 2011-08-18 15:40:15 PDT
Created attachment 104412 [details] Patch which should build on Mac 10.6
WebKit Review Bot
Comment 6 2011-08-18 15:47:11 PDT
Comment on attachment 104412 [details] Patch which should build on Mac 10.6 Attachment 104412 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9423826
Beth Dakin
Comment 7 2011-08-18 16:45:15 PDT
Created attachment 104424 [details] Patch, another attempt at building on 10.6
Sam Weinig
Comment 8 2011-08-18 17:08:21 PDT
Comment on attachment 104424 [details] Patch, another attempt at building on 10.6 View in context: https://bugs.webkit.org/attachment.cgi?id=104424&action=review > Source/WebCore/ChangeLog:49 > + (WebCore::ScrollbarThemeMac::paint): I don't think you need this wall of text if you aren't going to comment about it.
Beth Dakin
Comment 9 2011-08-18 17:46:11 PDT
Thanks Sam! Committed change with some in-person suggestions with revision 93377.
Note You need to log in before you can comment on or make changes to this bug.