Bug 66494 - add embedded png checksums to WebKitTestRunner
Summary: add embedded png checksums to WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 12:42 PDT by Tony Chang
Modified: 2011-08-18 15:08 PDT (History)
1 user (show)

See Also:


Attachments
Patch (23.15 KB, patch)
2011-08-18 12:45 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (23.93 KB, patch)
2011-08-18 14:09 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-08-18 12:42:47 PDT
add embedded png checksums to WebKitTestRunner
Comment 1 Tony Chang 2011-08-18 12:45:37 PDT
Created attachment 104385 [details]
Patch
Comment 2 Darin Adler 2011-08-18 13:00:15 PDT
Comment on attachment 104385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104385&action=review

> Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:59
> +    unsigned crc = 0xffffffffL;

I know this is just copied code, but I should point out that this is wrong. If we want an unsigned constant it should be 0xffffffffU. Adding the "L" prefix makes it a long, so the type should be "long", not "unsigned".

> Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:61
> +        crc = crcTable[(crc ^ buffer[i]) & 0xff] ^ ((crc >> 8) & 0x00ffffffL);

The L is not helpful. A U would be helpful.

> Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:62
> +    return crc ^ 0xffffffffL;

The L is not helpful. A U would be helpful.
Comment 3 Tony Chang 2011-08-18 14:09:12 PDT
Created attachment 104395 [details]
Patch for landing
Comment 4 WebKit Review Bot 2011-08-18 15:08:42 PDT
Comment on attachment 104395 [details]
Patch for landing

Clearing flags on attachment: 104395

Committed r93355: <http://trac.webkit.org/changeset/93355>
Comment 5 WebKit Review Bot 2011-08-18 15:08:46 PDT
All reviewed patches have been landed.  Closing bug.