Bug 66493 – Added Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Fady Samuel]

Added Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac

[Fady Samuel]

Created attachment 104383 [details]
Patch

[Fady Samuel]

Added test expectations for WebKit1 Mac (which remains broken after https://bugs.webkit.org/show_bug.cgi?id=57785), and WebKit2 Mac.

[Adam Roben (:aroben)]

Comment on attachment 104383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104383&action=review

> LayoutTests/ChangeLog:12
> +        * platform/mac-wk2/fast/frames/frame-set-scaling-3d-expected.png: Added.
> +        * platform/mac-wk2/fast/frames/frame-set-scaling-centered-expected.png: Added.
> +        * platform/mac-wk2/fast/frames/frame-set-scaling-expected.png: Added.
> +        * platform/mac-wk2/fast/frames/frame-set-scaling-rotate-expected.png: Added.
> +        * platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.

Are these copied from the cross-platform results? You should say so if so.

[Fady Samuel]

(In reply to comment #3)
> (From update of attachment 104383 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104383&action=review
> 
> > LayoutTests/ChangeLog:12
> > +        * platform/mac-wk2/fast/frames/frame-set-scaling-3d-expected.png: Added.
> > +        * platform/mac-wk2/fast/frames/frame-set-scaling-centered-expected.png: Added.
> > +        * platform/mac-wk2/fast/frames/frame-set-scaling-expected.png: Added.
> > +        * platform/mac-wk2/fast/frames/frame-set-scaling-rotate-expected.png: Added.
> > +        * platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.
> 
> Are these copied from the cross-platform results? You should say so if so.

Yes, they are. Should that be in the changelog? I guess I dont' quite understand how results are prioritized. Would webkit2 look at the mac results first or the cross-platform results first?

[Adam Roben (:aroben)]

Comment on attachment 104383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104383&action=review

>>> LayoutTests/ChangeLog:12
>>> +        * platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.
>> 
>> Are these copied from the cross-platform results? You should say so if so.
> 
> Yes, they are. Should that be in the changelog? I guess I dont' quite understand how results are prioritized. Would webkit2 look at the mac results first or the cross-platform results first?

Yes, I think it should be in the ChangeLog. The ChangeLog should explain the problem (WebKit1 and WebKit2 give different results) and the solution (add WebKit1 results and copy cross-platform results into the WebKit2 directory).

WebKit2 on Lion will look at results in this order:

mac-wk2
mac-lion
mac
cross platform

[Adam Roben (:aroben)]

(In reply to comment #5)
> The ChangeLog should explain the problem and the solution.

This is true for all patches, btw.

[Fady Samuel]

Created attachment 104386 [details]
Patch

[WebKit Review Bot]

Comment on attachment 104386 [details]
Patch

Attachment 104386 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9389023

New failing tests:
fast/frames/frame-set-scaling.html
fast/frames/frame-set-scaling-centered.html

[WebKit Review Bot]

Comment on attachment 104386 [details]
Patch

Rejecting attachment 104386 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
vg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT

Regressions: Unexpected image mismatch : (7)
  fast/frames/frame-set-scaling-centered.html = IMAGE
  fast/frames/frame-set-scaling.html = IMAGE
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/9421861

[Tony Chang]

Oh, so the problem is that chromium looks at the mac results before falling back to the cross platform results.

I think you need to also copy the cross platform results into LayoutTests/platform/chromium/

Sorry :(

[Fady Samuel]

(In reply to comment #10)
> Oh, so the problem is that chromium looks at the mac results before falling back to the cross platform results.
> 
> I think you need to also copy the cross platform results into LayoutTests/platform/chromium/
> 
> Sorry :(

Sigh, for the record, could you please tell me the order in which chromium platforms look for results..I know this is a lot of typing but understanding this is very important.

[Fady Samuel]

(In reply to comment #11)
> (In reply to comment #10)
> > Oh, so the problem is that chromium looks at the mac results before falling back to the cross platform results.
> > 
> > I think you need to also copy the cross platform results into LayoutTests/platform/chromium/
> > 
> > Sorry :(
> 
> Sigh, for the record, could you please tell me the order in which chromium platforms look for results..I know this is a lot of typing but understanding this is very important.

Better yet, is this documented somewhere?

[Tony Chang]

(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > Oh, so the problem is that chromium looks at the mac results before falling back to the cross platform results.
> > > 
> > > I think you need to also copy the cross platform results into LayoutTests/platform/chromium/
> > > 
> > > Sorry :(
> > 
> > Sigh, for the record, could you please tell me the order in which chromium platforms look for results..I know this is a lot of typing but understanding this is very important.
> 
> Better yet, is this documented somewhere?

https://docs.google.com/a/chromium.org/drawings/d/1z65SKkWrD4Slm6jobIphHwwRADyUtjOAxwGBVKBY8Kc/edit?hl=en_US

Unfortunately the document doesn't include wk2.

[Fady Samuel]

Created attachment 104413 [details]
Patch

[Tony Chang]

Comment on attachment 104413 [details]
Patch

Wait, the chromium and mac-wk2 results are missing the checksums.

[Tony Chang]

(In reply to comment #15)
> (From update of attachment 104413 [details])
> Wait, the chromium and mac-wk2 results are missing the checksums.

In r93320, the checksums were added to the cross platform results.  You should be able to copy those files.

Also, in r93355, I fixed WebKitTestRunner to actually embed the checksums in the png files, so if you can generate the mac-wk2 pngs after that revision, they should include checksums.

All this happened to work because ORWT will just do full file compares if the checksum isn't found.  NRWT will complain, but wk2 is still using ORWT.

[Fady Samuel]

Created attachment 104420 [details]
Patch

[WebKit Review Bot]

Comment on attachment 104420 [details]
Patch

Clearing flags on attachment: 104420

Committed r93371: <http://trac.webkit.org/changeset/93371>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.