Bug 66486 - "Could not find apache" reported even though apache is found
Summary: "Could not find apache" reported even though apache is found
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tom Zakrajsek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 11:09 PDT by Tom Zakrajsek
Modified: 2011-08-19 09:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2011-08-18 11:21 PDT, Tom Zakrajsek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Zakrajsek 2011-08-18 11:09:25 PDT 
In Tools/Scripts/webkitpy/layout_tests/port/webkit.py, there is a problem in _path_to_apache. The error message is inside the loop so it prints unless the first path is the right one.  Fix is simple.  Outdent _log.error one level.
Comment 1 Tom Zakrajsek 2011-08-18 11:21:35 PDT 
Created attachment 104369 [details]
Patch
Comment 2 Ryosuke Niwa 2011-08-18 11:26:30 PDT 
Comment on attachment 104369 [details]
Patch

this looks like a no-brainer so r=me.
Comment 3 WebKit Review Bot 2011-08-19 09:07:02 PDT 
Comment on attachment 104369 [details]
Patch

Clearing flags on attachment: 104369

Committed r93416: <http://trac.webkit.org/changeset/93416>
Comment 4 WebKit Review Bot 2011-08-19 09:07:06 PDT 
All reviewed patches have been landed.  Closing bug.