Bug 66478 - Fix rubber band gutter drawing for Skia on Chromium Mac
Summary: Fix rubber band gutter drawing for Skia on Chromium Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cary Clark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 10:19 PDT by Cary Clark
Modified: 2011-08-18 13:23 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2011-08-18 10:21 PDT, Cary Clark 		no flags Details | Formatted Diff | Diff
Patch (1.96 KB, patch)
2011-08-18 10:24 PDT, Cary Clark 		no flags Details | Formatted Diff | Diff
Patch (2.05 KB, patch)
2011-08-18 11:00 PDT, Cary Clark 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cary Clark 2011-08-18 10:19:29 PDT 
Fix Rubber band gutter drawing for Skia on Chromium Mac
Comment 1 Cary Clark 2011-08-18 10:21:51 PDT 
Created attachment 104359 [details]
Patch
Comment 2 Cary Clark 2011-08-18 10:24:31 PDT 
Created attachment 104360 [details]
Patch
Comment 3 WebKit Review Bot 2011-08-18 10:24:44 PDT 
Attachment 104359 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 James Robinson 2011-08-18 10:44:30 PDT 
Comment on attachment 104360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104360&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests. The Skia on Chromium Mac platform has
> +        not been enabled.

We have bots for this config now, don't we?  If we had bots, would they catch this issue?  Is this a compile-time issue or something that shows up at runtime?
Comment 5 Cary Clark 2011-08-18 11:00:35 PDT 
Created attachment 104365 [details]
Patch
Comment 6 James Robinson 2011-08-18 11:01:22 PDT 
Comment on attachment 104365 [details]
Patch

R=me
Comment 7 WebKit Review Bot 2011-08-18 13:23:09 PDT 
Comment on attachment 104365 [details]
Patch

Clearing flags on attachment: 104365

Committed r93343: <http://trac.webkit.org/changeset/93343>
Comment 8 WebKit Review Bot 2011-08-18 13:23:13 PDT 
All reviewed patches have been landed.  Closing bug.