Bug 66475 - Fix clang libc++ C++0x build
Summary: Fix clang libc++ C++0x build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 09:54 PDT by Anders Carlsson
Modified: 2011-08-18 10:47 PDT (History)
0 users

See Also:

Attachments
Patch (1.93 KB, patch)
2011-08-18 09:55 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-08-18 09:54:32 PDT 
Fix clang libc++ C++0x build
Comment 1 Anders Carlsson 2011-08-18 09:55:33 PDT 
Created attachment 104353 [details]
Patch
Comment 2 Anders Carlsson 2011-08-18 09:56:24 PDT 
Committed r93316: <http://trac.webkit.org/changeset/93316>
Comment 3 Darin Adler 2011-08-18 10:47:29 PDT 
Comment on attachment 104353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104353&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:-3907
> -    if (isnan(width))
> -        width = 100;
> -    if (isnan(height))
> -        height = 100;

I think this indicates a bug. We are probably making width and height be 0 if you pass undefined from JavaScript rather than 100. Someone working on WebGL should probably look into this and make a test case.