Bug 66470 - IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity
Summary: IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 08:20 PDT by jochen
Modified: 2011-08-19 05:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2011-08-18 08:20 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch (1.78 KB, patch)
2011-08-18 10:53 PDT, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2011-08-18 08:20:06 PDT 
Delete object store data while maintaining referential integrity
Comment 1 jochen 2011-08-18 08:20:26 PDT 
Created attachment 104345 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-08-18 10:37:57 PDT 
I had difficulty parsing the bug title, so re-titling for others' benefit. Please correct it if I misunderstood something.
Comment 3 jochen 2011-08-18 10:51:59 PDT 
no, you're right. thanks for updating the title
Comment 4 jochen 2011-08-18 10:53:47 PDT 
Created attachment 104364 [details]
Patch
Comment 5 David Grogan 2011-08-18 11:34:03 PDT 
LGTM

Was sqlite returning an error because the references would be broken?
Comment 6 jochen 2011-08-18 11:37:01 PDT 
(In reply to comment #5)
> LGTM
> 
> Was sqlite returning an error because the references would be broken?

I don't know, it just occurred to me while working on that file that this is broken.

doDelete doesn't do error checking :(

and I think we don't check that code at all, as the layoutTests are executed with the leveldb backend afaik double-:(
Comment 7 WebKit Review Bot 2011-08-19 05:13:34 PDT 
Comment on attachment 104364 [details]
Patch

Clearing flags on attachment: 104364

Committed r93395: <http://trac.webkit.org/changeset/93395>
Comment 8 WebKit Review Bot 2011-08-19 05:13:38 PDT 
All reviewed patches have been landed.  Closing bug.