Bug 66467 – BORDER attribute percent with the input image tag not working.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Mihnea Ovidenie]

Take into account border attribute for input element of type image. This is a follow up for 20226 and 65176.

[Mihnea Ovidenie]

Created attachment 104341 [details]
Patch

[WebKit Review Bot]

Comment on attachment 104341 [details]
Patch

Attachment 104341 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9424635

New failing tests:
fast/dom/HTMLInputElement/input-image-alt-text.html

[Mihnea Ovidenie]

Created attachment 104485 [details]
Patch 2

Mark the test: fast/dom/HTMLInputElement/input-image-alt-text.html as failing in Chromium since its expectations must be regenerated.

[Simon Fraser (smfr)]

Comment on attachment 104485 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=104485&action=review

> Source/WebCore/ChangeLog:9
> +        An image input element takes border attribute into account.
> +        If percent is specified in the border attribute, that percent is ignored.

This doesn't really tell me what the original problem was, and how you fixed it.

[Mihnea Ovidenie]

Created attachment 105953 [details]
Patch 3

Reworked changelog explanation for the patch.

[WebKit Review Bot]

Comment on attachment 105953 [details]
Patch 3

Rejecting attachment 105953 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
es a/LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png and b/LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png differ".  Be sure to use the --binary flag when invoking "git diff" with diffs containing binary files. at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 668, <ARGV> line 97.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Simon Fraser', u'--for..." exit_code: 9

Full output: http://queues.webkit.org/results/9580286

[Mihnea Ovidenie]

Created attachment 106106 [details]
Patch 4

Forgot to add the binary image in the prev patch.

[WebKit Review Bot]

Comment on attachment 106106 [details]
Patch 4

Clearing flags on attachment: 106106

Committed r94425: <http://trac.webkit.org/changeset/94425>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Zoltan Horvath]

Qt specific result has been landed in http://trac.webkit.org/changeset/94523.