Bug 66460 - Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
Summary: Web Inspector: [Extensions API] rename webInspector.resources to webInspector...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 06:03 PDT by Andrey Kosyakov
Modified: 2011-09-26 00:32 PDT (History)
11 users (show)

See Also:


Attachments
patch (73.68 KB, patch)
2011-08-18 06:06 PDT, Andrey Kosyakov
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch (74.45 KB, patch)
2011-08-18 07:30 PDT, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-08-18 06:03:10 PDT
- rename webInspector.resources namespace to webInspector.network to be consistent with the rest of inspector
- use term request instead of resource for network request related code
- rename webInspector.network.onFinished to webInspector.network.onRequestFinished
Comment 1 Andrey Kosyakov 2011-08-18 06:06:26 PDT
Created attachment 104330 [details]
patch
Comment 2 WebKit Review Bot 2011-08-18 06:40:46 PDT
Comment on attachment 104330 [details]
patch

Attachment 104330 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9426351

New failing tests:
http/tests/inspector/extensions-network-redirect.html
Comment 3 Andrey Kosyakov 2011-08-18 07:30:14 PDT
Created attachment 104339 [details]
patch

- renamed a test in the chromium test expectations
Comment 4 Andrey Kosyakov 2011-09-26 00:32:27 PDT
Manually committed r93312: http://trac.webkit.org/changeset/93312