Bug 66458 – [Refactoring] Add EventDispatchMediator.{h,cpp} and move related classes to that files.

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Hayato Ito]

Now Event.{h,cpp} contain EventDispatchMediator and Focus/BlurEventDispatchMediator's declarations and definitions.

It might be good to have EventDispatchMediator.{h,cpp} and move related classes to that files from Event.{h,cpp}.

[Hayato Ito]

Created attachment 104329 [details]
refactoring

[Ryosuke Niwa]

Comment on attachment 104329 [details]
refactoring

View in context: https://bugs.webkit.org/attachment.cgi?id=104329&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26192
> +				4AF1AD3E13FD23A400AA9590 /* EventDispatchMediator.cpp in Sources */,

Please sort this lexicologically.

> Source/WebCore/dom/EventDispatchMediator.h:62
> +inline EventDispatchMediator::EventDispatchMediator()
> +{
> +}

It appears that this can be included in the class declaration.

> Source/WebCore/dom/EventDispatchMediator.h:67
> +inline Event* EventDispatchMediator::event() const
> +{
> +    return m_event.get();
> +}

Ditto.

> Source/WebCore/dom/EventDispatchMediator.h:72
> +inline void EventDispatchMediator::setEvent(PassRefPtr<Event> event)
> +{
> +    m_event = event;
> +}

Ditto.

[Hayato Ito]

Comment on attachment 104329 [details]
refactoring

Thank you for the review.
I'll land this patch after addressing your comments and confirming that can be compiled on all platforms.

View in context: https://bugs.webkit.org/attachment.cgi?id=104329&action=review

>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26192
>> +				4AF1AD3E13FD23A400AA9590 /* EventDispatchMediator.cpp in Sources */,
> 
> Please sort this lexicologically.

Done. Thank you.
I wrongly assumed that these don't have to be sorted because I spotted these are not 'locally' sorted around there. I should have taken a look at that globally. :)

>> Source/WebCore/dom/EventDispatchMediator.h:62
>> +}
> 
> It appears that this can be included in the class declaration.

Done.

>> Source/WebCore/dom/EventDispatchMediator.h:67
>> +}
> 
> Ditto.

Done.

>> Source/WebCore/dom/EventDispatchMediator.h:72
>> +}
> 
> Ditto.

Done.

[Hayato Ito]

Created attachment 104451 [details]
to make sure that the patch can be compiled on all platforms. not for review

[Hayato Ito]

Committed r93385: <http://trac.webkit.org/changeset/93385>

[Adam Roben (:aroben)]

Windows build fix in r93408

[Hayato Ito]

Hi, Adam

(In reply to comment #6)
> Windows build fix in r93408

Thank you for the fix, and I'm sorry for the build broken in Windows.
The lesson is that I have to edit dom/DOMAllInOne.cpp also.