Bug 66417 - [chromium] fast/text/midword-break-before-surrogate-pair-2.html should be redesigned
Summary: [chromium] fast/text/midword-break-before-surrogate-pair-2.html should be red...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-17 15:15 PDT by Tony Chang
Modified: 2013-04-08 14:33 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-08-17 15:15:26 PDT
The following layout test is failing on Chromium Win and Linux

fast/text/midword-break-before-surrogate-pair-2.html

Probable cause:

We don't have glyphs for the emoji characters used in the test.  It would be nice if we could have the test use a different character.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Ftext%2Fmidword-break-before-surrogate-pair-2.html

I will mark as failing for now.
Comment 1 Peter Kasting 2012-07-31 22:14:50 PDT
Also fails on Lion.
Comment 2 Peter Kasting 2012-07-31 22:29:29 PDT
From eseidel:  "I argue the test is poorly designed and needs to be fixed to work better across platforms."
From rniwa: "We should just skip these tests."

I tend to side with eseidel here but what do I know.

The Lion results changed with http://trac.webkit.org/changeset/124295 so this test is pretty sensitive to wrapping issues.
Comment 3 Ryosuke Niwa 2012-07-31 22:32:13 PDT
Dan, isn't this test supposed to be ran only on Lion and onwards? We should probably move it to platform/mac.
Comment 4 mitz 2012-07-31 22:37:38 PDT
There was nothing platform-specific about the code change that this test covers, but I don’t know if non-OS X platforms have a font that would make it possible to test this. It seems OK to move the test to platform/mac.
Comment 5 Ryosuke Niwa 2012-07-31 22:50:21 PDT
(In reply to comment #4)
> There was nothing platform-specific about the code change that this test covers, but I don’t know if non-OS X platforms have a font that would make it possible to test this. It seems OK to move the test to platform/mac.

Can we reproduce the bug you were fixing using some other surrogate pairs?
Comment 6 mitz 2012-07-31 23:06:12 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > There was nothing platform-specific about the code change that this test covers, but I don’t know if non-OS X platforms have a font that would make it possible to test this. It seems OK to move the test to platform/mac.
> 
> Can we reproduce the bug you were fixing using some other surrogate pairs?

Like I said, I don’t know. I think none of the test fonts cover non-BMP characters.
Comment 7 Ryosuke Niwa 2013-02-03 14:08:34 PST
Levi, maybe you can look into this while you fix the midpoint bug in isolate.