Bug 66400 - Fix TestWebKitAPI build on Mac OS
Summary: Fix TestWebKitAPI build on Mac OS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dmitry Lomov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-17 13:05 PDT by Dmitry Lomov
Modified: 2011-08-17 21:47 PDT (History)
3 users (show)

See Also:

Attachments
Added ICU headers to HEADER_SEARCH_PATH. (1.73 KB, patch)
2011-08-17 13:08 PDT, Dmitry Lomov 		levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
Fix style nits. (1.73 KB, patch)
2011-08-17 13:20 PDT, Dmitry Lomov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lomov 2011-08-17 13:05:45 PDT 
StringOperations.cpp fail to build due to ICU headers missing
Comment 1 Dmitry Lomov 2011-08-17 13:08:41 PDT 
Created attachment 104218 [details]
Added ICU headers to HEADER_SEARCH_PATH.
Comment 2 Mark Rowe (bdash) 2011-08-17 13:11:28 PDT 
Comment on attachment 104218 [details]
Added ICU headers to HEADER_SEARCH_PATH.

View in context: https://bugs.webkit.org/attachment.cgi?id=104218&action=review

> Tools/ChangeLog:4
> +        Fix TestWebKitAPI build on MacOS.

Mac OS.

> Tools/ChangeLog:8
> +        * TestWebKitAPI/Configurations/Base.xcconfig:Added ICU headers to the HEADER_SEARCH_PATH.

We typically leave some space after the colon rather than jamming the message right up against it.
Comment 3 Dmitry Lomov 2011-08-17 13:17:10 PDT 
(In reply to comment #2)

> We typically leave some space after the colon rather than jamming the message right up against it.

check-webkit-style should report this.
Comment 4 Dmitry Lomov 2011-08-17 13:20:25 PDT 
Created attachment 104221 [details]
Fix style nits.
Comment 5 Dmitry Lomov 2011-08-17 16:22:25 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> 
> > We typically leave some space after the colon rather than jamming the message right up against it.
> 
> check-webkit-style should report this.

https://bugs.webkit.org/show_bug.cgi?id=66425
Comment 6 WebKit Review Bot 2011-08-17 21:47:31 PDT 
Comment on attachment 104221 [details]
Fix style nits.

Clearing flags on attachment: 104221

Committed r93282: <http://trac.webkit.org/changeset/93282>
Comment 7 WebKit Review Bot 2011-08-17 21:47:36 PDT 
All reviewed patches have been landed.  Closing bug.