Bug 66380 - [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
Summary: [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leandro Pereira
URL:
Keywords:
: 66415 (view as bug list)
Depends on: 66685 66782 68454
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-17 08:24 PDT by Leandro Pereira
Modified: 2011-10-07 09:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.75 KB, patch)
2011-08-17 09:54 PDT, Leandro Pereira 		no flags Details | Formatted Diff | Diff
Updated patch which also changes related files (31.36 KB, patch)
2011-09-20 11:29 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Rebase on top of trunk (31.32 KB, patch)
2011-10-05 11:53 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2011-08-17 08:24:36 PDT 
[EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
Comment 1 Leandro Pereira 2011-08-17 09:54:35 PDT 
Created attachment 104182 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-09-20 10:49:07 PDT 
*** Bug 66415 has been marked as a duplicate of this bug. ***
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-09-20 10:50:44 PDT 
Updating dependency list.
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-09-20 11:29:08 PDT 
Created attachment 108032 [details]
Updated patch which also changes related files
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-10-02 21:34:41 PDT 
CC'ing reviewers.
Comment 6 Kenneth Rohde Christiansen 2011-10-03 09:16:57 PDT 
Comment on attachment 108032 [details]
Updated patch which also changes related files

View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review

> Tools/ChangeLog:11
> +        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.

I think the name Chrome is very confusing due to EFL vs Chromium.
Comment 7 Raphael Kubo da Costa (:rakuco) 2011-10-03 09:30:06 PDT 
(In reply to comment #6)
> (From update of attachment 108032 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review
> 
> > Tools/ChangeLog:11
> > +        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
> 
> I think the name Chrome is very confusing due to EFL vs Chromium.

It was named after ChromeClient and friends. Is it worth renaming it? Any suggestions?
Comment 8 Raphael Kubo da Costa (:rakuco) 2011-10-05 11:53:54 PDT 
Created attachment 109831 [details]
Rebase on top of trunk
Comment 9 Antonio Gomes 2011-10-07 09:04:55 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 108032 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review
> > 
> > > Tools/ChangeLog:11
> > > +        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
> > 
> > I think the name Chrome is very confusing due to EFL vs Chromium.
> 
> It was named after ChromeClient and friends. Is it worth renaming it? Any suggestions?

I tend to agree, but on the other hand I have not better suggestion.
Comment 10 WebKit Review Bot 2011-10-07 09:21:07 PDT 
Comment on attachment 109831 [details]
Rebase on top of trunk

Clearing flags on attachment: 109831

Committed r96943: <http://trac.webkit.org/changeset/96943>
Comment 11 WebKit Review Bot 2011-10-07 09:21:13 PDT 
All reviewed patches have been landed.  Closing bug.