Bug 66380 – [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Leandro Pereira]

[EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}

[Leandro Pereira]

Created attachment 104182 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

*** Bug 66415 has been marked as a duplicate of this bug. ***

[Raphael Kubo da Costa (:rakuco)]

Updating dependency list.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 108032 [details]
Updated patch which also changes related files

[Raphael Kubo da Costa (:rakuco)]

CC'ing reviewers.

[Kenneth Rohde Christiansen]

Comment on attachment 108032 [details]
Updated patch which also changes related files

View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review

> Tools/ChangeLog:11
> +        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.

I think the name Chrome is very confusing due to EFL vs Chromium.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #6)
> (From update of attachment 108032 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review
> 
> > Tools/ChangeLog:11
> > +        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
> 
> I think the name Chrome is very confusing due to EFL vs Chromium.

It was named after ChromeClient and friends. Is it worth renaming it? Any suggestions?

[Raphael Kubo da Costa (:rakuco)]

Created attachment 109831 [details]
Rebase on top of trunk

[Antonio Gomes]

(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 108032 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review
> > 
> > > Tools/ChangeLog:11
> > > +        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
> > 
> > I think the name Chrome is very confusing due to EFL vs Chromium.
> 
> It was named after ChromeClient and friends. Is it worth renaming it? Any suggestions?

I tend to agree, but on the other hand I have not better suggestion.

[WebKit Review Bot]

Comment on attachment 109831 [details]
Rebase on top of trunk

Clearing flags on attachment: 109831

Committed r96943: <http://trac.webkit.org/changeset/96943>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.