Bug 66366 - [EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view.
Summary: [EFL] Private function _ewk_view_viewport_attributes_compute takes an interna...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-17 02:31 PDT by Grzegorz Czajkowski
Modified: 2011-10-26 01:26 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (2.23 KB, patch)
2011-08-17 02:32 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
updated patch to a new coding style of WebKit-EFL (2.37 KB, patch)
2011-10-21 06:53 PDT, Grzegorz Czajkowski 		rniwa: review+
Details | Formatted Diff | Diff
followed Ryosuke's suggestions (2.28 KB, patch)
2011-10-26 01:13 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2011-08-17 02:31:48 PDT 
Passes to _ewk_view_viewport_attributes_compute an internal data of ewk_view instead of the view object.
Adds to ewk_view_viewport_attributes_get NULL checking to avoid unexpected results since this is API.
Comment 1 Grzegorz Czajkowski 2011-08-17 02:32:31 PDT 
Created attachment 104160 [details]
proposed patch
Comment 2 Gyuyoung Kim 2011-08-17 03:06:36 PDT 
Comment on attachment 104160 [details]
proposed patch

LGTM
Comment 3 Leandro Pereira 2011-08-17 07:10:59 PDT 
Comment on attachment 104160 [details]
proposed patch

Informal r+.
Comment 4 Grzegorz Czajkowski 2011-10-21 06:53:10 PDT 
Created attachment 111960 [details]
updated patch to a new coding style of WebKit-EFL
Comment 5 Ryosuke Niwa 2011-10-26 00:33:03 PDT 
Comment on attachment 111960 [details]
updated patch to a new coding style of WebKit-EFL

View in context: https://bugs.webkit.org/attachment.cgi?id=111960&action=review

> Source/WebKit/efl/ChangeLog:9
> +        Passes to _ewk_view_viewport_attributes_compute an internal
> +        data of ewk_view instead of the view object.

This can fit in one line.

> Source/WebKit/efl/ChangeLog:11
> +        Adds to ewk_view_viewport_attributes_get NULL checks to
> +        avoid unexpected results since this is API.

Ditto.
Comment 6 Grzegorz Czajkowski 2011-10-26 01:13:38 PDT 
Created attachment 112466 [details]
followed Ryosuke's suggestions
Comment 7 WebKit Review Bot 2011-10-26 01:26:52 PDT 
Comment on attachment 112466 [details]
followed Ryosuke's suggestions

Clearing flags on attachment: 112466

Committed r98446: <http://trac.webkit.org/changeset/98446>
Comment 8 WebKit Review Bot 2011-10-26 01:26:57 PDT 
All reviewed patches have been landed.  Closing bug.