Bug 66352 – Some AVFoundation source files should be in platform-specific directories

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeff Miller]

Currently, all AVFoundation source files are in Source/WebCore/platform/graphics/AVFoundation. The platform-specific files should be moved to Source/WebCore/platform/graphics/mac and Source/WebCore/platform/graphics/win.

[Radar WebKit Bug Importer]

<rdar://problem/9965771>

[Adam Roben (:aroben)]

Or maybe platform/graphics/AVFoundation/{cf,objc} would be better?

[Jeff Miller]

(In reply to comment #2)
> Or maybe platform/graphics/AVFoundation/{cf,objc} would be better?

I considered that, but other platform-specific MediaPlayer files (like MediaPlayerPrivateQTKit.mm and MediaPlayerPrivateQuickTimeVisualContext.cpp) are in the /mac and /win directories in platform/graphics already.

But I don't have a strong opinion about this, although if we were to put them in AVFoundation I think we should stick with AVFoundation/mac and AVFoundation/win, since it matches the well-known naming convention and these really are Mac and Windows-specific.

What do you think?

[Adam Roben (:aroben)]

Are you going to rename the MediaPlayerPrivateAVFoundationCF/ObjC class to use the Mac/Win convention, too?

It makes sense to me to have these files be in a directory beneath the directory that contains MediaPlayerPrivateAVFoundation.h/cpp. So if that file is in platform/graphics/avfoundation then these files should be in platform/graphics/avfoundation/foo.

[Jeff Miller]

(In reply to comment #4)
> Are you going to rename the MediaPlayerPrivateAVFoundationCF/ObjC class to use the Mac/Win convention, too?

Good point. Renaming the files isn't a big deal, but I'd have to rename the classes as well.

> It makes sense to me to have these files be in a directory beneath the directory that contains MediaPlayerPrivateAVFoundation.h/cpp. So if that file is in platform/graphics/avfoundation then these files should be in platform/graphics/avfoundation/foo.

OK. I will use platform/graphics/AVFoundation/{cf,objc} as you suggested, rather than renaming things further.

Adding Eric to the cc list to see if he has an opinion.

[Eric Carlson]

I don't actually think moving or renaming the files is necessary. I definitely don't' think it makes sense to move them to platform/graphics/{mac, win}, but if you think more structure will be helpful platform/graphics/AVFoundation/{cf,objc} seems the most logical.

[Jeff Miller]

Maybe a little context would be helpful.  To address <https://bugs.webkit.org/show_bug.cgi?id=65725>, I plan on adding the Windows-specific files AVFoundationCFSoftLink.h, CoreMediaSoftLink.h, and libdispatchSoftLink.h. Rather than putting these in avfoundation, I thought the increased number of platform-specific files warranted reorganizing avfoundation.

Eric, given that, if you still don't think reorganizing is necessary, I'll be glad to close out this bug.

[Jeff Miller]

I talked to Eric offline, and given my last comment he thinks making objc and cf directories is the right thing to do. Patch coming soon.

[Jeff Miller]

Created attachment 104193 [details]
Patch

[Jeff Miller]

Committed r93219: <http://trac.webkit.org/changeset/93219>