Bug 66343 - Wire up relative time to garden-o-matic summary view.
Summary: Wire up relative time to garden-o-matic summary view.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64188 66403
  Show dependency tree / graph
 
Reported: 2011-08-16 15:37 PDT by Dimitri Glazkov (Google)
Modified: 2011-08-17 14:13 PDT (History)
1 user (show)

See Also:

Attachments
Patch (8.00 KB, patch)
2011-08-16 15:39 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Patch (9.97 KB, patch)
2011-08-16 15:44 PDT, Dimitri Glazkov (Google) 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-08-16 15:37:02 PDT 
Wire up relative time to garden-o-matic summary view.
Comment 1 Dimitri Glazkov (Google) 2011-08-16 15:39:24 PDT 
Created attachment 104103 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-08-16 15:44:11 PDT 
Created attachment 104105 [details]
Patch
Comment 3 Adam Barth 2011-08-16 17:16:48 PDT 
Comment on attachment 104105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104105&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:73
> +    get date()

I'd prefer not to use getters and settings, but we can use them if you feel strongly.  They secretly turn property accesses into function calls that can do scary things.
Comment 4 Dimitri Glazkov (Google) 2011-08-16 18:23:12 PDT 
Comment on attachment 104105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104105&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:73
>> +    get date()
> 
> I'd prefer not to use getters and settings, but we can use them if you feel strongly.  They secretly turn property accesses into function calls that can do scary things.

I totally agree with you. I keep wanting to use getters and setters, because they are fancy, but always worry about the foot-gun problem. I'll change to use WebKit style date() and setDate().
Comment 5 Dimitri Glazkov (Google) 2011-08-17 14:13:39 PDT 
Committed r93241: <http://trac.webkit.org/changeset/93241>