Bug 66337 – Cleanup "ShouldRetain" enum access in FontCacheChromiumWin

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore Misc.

[Joseph Pecoraro]

While fixing <http://webkit.org/b/66153> I had to make a number of
follow-up fixes for Chromium Windows:
<http://trac.webkit.org/changeset/93151>
<http://trac.webkit.org/changeset/93156>
<http://trac.webkit.org/changeset/93160>

This code should be cleaned up so that either:

  (1) the ShouldRetain enum should be kept public and
      we can then remove getNonRetainLastResortCallbackFunction
      and fix call sites.

  (2) or, as was intended, make the ShouldRetain enum
      private again, and fix Chromium Win to work with the
      private enum. Most likely by making the Chromium struct
      GetLastResortFallbackFontProcData a friend of FontCache.

Please let me know if you have any questions!

[Hironori Bono]

Greetings,

In my personal opinion, (2) seems better because I do not like to change the original intention of this enum. I will create a change that moves this enum to the original position and change this file.

Regards,

Hironori Bono
E-mail: [e-mail]

(In reply to comment #0)
> While fixing <http://webkit.org/b/66153> I had to make a number of
> follow-up fixes for Chromium Windows:
> <http://trac.webkit.org/changeset/93151>
> <http://trac.webkit.org/changeset/93156>
> <http://trac.webkit.org/changeset/93160>
> 
> This code should be cleaned up so that either:
> 
>   (1) the ShouldRetain enum should be kept public and
>       we can then remove getNonRetainLastResortCallbackFunction
>       and fix call sites.
> 
>   (2) or, as was intended, make the ShouldRetain enum
>       private again, and fix Chromium Win to work with the
>       private enum. Most likely by making the Chromium struct
>       GetLastResortFallbackFontProcData a friend of FontCache.
> 
> Please let me know if you have any questions!