RESOLVED FIXED 66332
change references to leveldb.gyp to leveldatabase.gyp 
https://bugs.webkit.org/show_bug.cgi?id=66332
Summary change references to leveldb.gyp to leveldatabase.gyp
David Grogan
Reported 2011-08-16 14:38:38 PDT
change references to leveldb.gyp to leveldatabase.gyp
Attachments
Patch (1.61 KB, patch)
2011-08-16 14:53 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2011-08-17 11:03 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2011-08-16 14:53:08 PDT
Created attachment 104095 [details] Patch
David Grogan
Comment 2 2011-08-16 14:53:36 PDT
Hans, would you like to review?
Hans Wennborg
Comment 3 2011-08-17 05:54:09 PDT
Looks good to me! It will be very nice to get this sorted out.
David Grogan
Comment 4 2011-08-17 08:53:03 PDT
Tony, could you review this? This is stage 3 of the plan described here: http://code.google.com/p/chromium/issues/detail?id=89378 The summary is that we're splitting up the leveldb code so that chromium-specific bits will live in the chromium repository. This patch makes webcore use the new leveldb checkout.
WebKit Review Bot
Comment 5 2011-08-17 09:38:31 PDT
Comment on attachment 104095 [details] Patch Rejecting attachment 104095 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: romium/test_expectations.txt Auto-merging LayoutTests/platform/win/Skipped Failed to merge in the changes. Patch failed at 0001 Add Windows results for new test added in r91777 When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 146. Full output: http://queues.webkit.org/results/9405922
David Grogan
Comment 6 2011-08-17 11:03:03 PDT
Created attachment 104194 [details] Patch
David Grogan
Comment 7 2011-08-17 11:09:45 PDT
Comment on attachment 104194 [details] Patch This is just a rebase to try to fix the patch-command problem. But it looks like it had nothing to with the patch, just git acting out. Could you r+ and cq+ this to see if it will land this time?
WebKit Review Bot
Comment 8 2011-08-17 20:25:11 PDT
Comment on attachment 104194 [details] Patch Clearing flags on attachment: 104194 Committed r93278: <http://trac.webkit.org/changeset/93278>
WebKit Review Bot
Comment 9 2011-08-17 20:25:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.