Bug 66324 - garden-o-matic frontend needs a friendly relative time description method.
Summary: garden-o-matic frontend needs a friendly relative time description method.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 66144
  Show dependency treegraph
 
Reported: 2011-08-16 13:04 PDT by Dimitri Glazkov (Google)
Modified: 2011-08-16 15:07 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.40 KB, patch)
2011-08-16 13:11 PDT, Dimitri Glazkov (Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-08-16 13:04:38 PDT
garden-o-matic frontend needs a friendly relative time description method.
Comment 1 Dimitri Glazkov (Google) 2011-08-16 13:11:55 PDT
Created attachment 104080 [details]
Patch
Comment 2 Adam Barth 2011-08-16 13:49:46 PDT
Comment on attachment 104080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104080&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:311
> +var MINUTE_IN_MILLISECONDS = 60 * 1000;

we've been using kMinuteInMilliseconds for these sorts of constants.
Comment 3 Adam Barth 2011-08-16 13:49:53 PDT
very cool
Comment 4 Dimitri Glazkov (Google) 2011-08-16 15:02:31 PDT
Comment on attachment 104080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104080&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:311
>> +var MINUTE_IN_MILLISECONDS = 60 * 1000;
> 
> we've been using kMinuteInMilliseconds for these sorts of constants.

D'oh. Will change.
Comment 5 Dimitri Glazkov (Google) 2011-08-16 15:07:51 PDT
Committed r93163: <http://trac.webkit.org/changeset/93163>