WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
66318
Summary view should not add multiple entries for the same test failure.
https://bugs.webkit.org/show_bug.cgi?id=66318
Summary
Summary view should not add multiple entries for the same test failure.
Dimitri Glazkov (Google)
Reported
2011-08-16 10:59:41 PDT
Summary view should not add multiple entries for the same test failure.
Attachments
Patch
(6.55 KB, patch)
2011-08-16 11:01 PDT
,
Dimitri Glazkov (Google)
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2011-08-16 11:01:37 PDT
Created
attachment 104068
[details]
Patch
Adam Barth
Comment 2
2011-08-16 13:47:52 PDT
Comment on
attachment 104068
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=104068&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:132 > + return !!Array.prototype.filter.call(this._tests.children, function(child) { > + return child.equals(failureAnalysis); > + }).length;
This feels like something to abstract into base, like the any/all functions in Python.
Dimitri Glazkov (Google)
Comment 3
2011-08-16 14:55:52 PDT
Committed
r93161
: <
http://trac.webkit.org/changeset/93161
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug