Bug 66318 - Summary view should not add multiple entries for the same test failure.
Summary: Summary view should not add multiple entries for the same test failure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 66144
  Show dependency treegraph
 
Reported: 2011-08-16 10:59 PDT by Dimitri Glazkov (Google)
Modified: 2011-08-16 14:55 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.55 KB, patch)
2011-08-16 11:01 PDT, Dimitri Glazkov (Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-08-16 10:59:41 PDT
Summary view should not add multiple entries for the same test failure.
Comment 1 Dimitri Glazkov (Google) 2011-08-16 11:01:37 PDT
Created attachment 104068 [details]
Patch
Comment 2 Adam Barth 2011-08-16 13:47:52 PDT
Comment on attachment 104068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104068&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:132
> +        return !!Array.prototype.filter.call(this._tests.children, function(child) {
> +            return child.equals(failureAnalysis);
> +        }).length;

This feels like something to abstract into base, like the any/all functions in Python.
Comment 3 Dimitri Glazkov (Google) 2011-08-16 14:55:52 PDT
Committed r93161: <http://trac.webkit.org/changeset/93161>