RESOLVED FIXED 66309
TestFailures thinks all tests passed in http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136 
https://bugs.webkit.org/show_bug.cgi?id=66309
Summary TestFailures thinks all tests passed in http://build.webkit.org/builders/Lion...
Adam Roben (:aroben)
Reported 2011-08-16 09:14:16 PDT
TestFailures thinks all tests passed in http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
Attachments
Patch (5.60 KB, patch)
2011-08-16 09:14 PDT, Adam Roben (:aroben) 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-08-16 09:14:53 PDT
Created attachment 104055 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2011-08-16 09:21:27 PDT
Comment on attachment 104055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104055&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:183 > +test("getNumberOfFailingTests treats unfinished test runs as errors", 4, function() { Nit: Extra space between "runs as".
Adam Roben (:aroben)
Comment 3 2011-08-16 09:26:31 PDT
Comment on attachment 104055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104055&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:183 >> +test("getNumberOfFailingTests treats unfinished test runs as errors", 4, function() { > > Nit: Extra space between "runs as". Fixed.
Adam Roben (:aroben)
Comment 4 2011-08-16 09:28:59 PDT
Committed r93111: <http://trac.webkit.org/changeset/93111>
Note You need to log in before you can comment on or make changes to this bug.