Bug 66303 - [REGRESSION] Media controls should always be enabled when scripting is disabled
: [REGRESSION] Media controls should always be enabled when scripting is disabled
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Media Elements
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
: InRadar
Depends on:
Blocks: 70872
  Show dependency treegraph
 
Reported: 2011-08-16 08:06 PDT by Eric Carlson
Modified: 2011-10-25 23:22 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (7.57 KB, patch)
2011-08-16 08:45 PDT, Eric Carlson
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-08-16 08:06:08 PDT
The spec says "... if scripting is disabled for the media element, then the user agent should expose a user interface to the user"[1]. WebKit previously forced controls to be visible when scripting was disabled, but that was lost along the way.

[1] http://www.w3.org/TR/html5/video.html#attr-media-controls
Comment 1 Radar WebKit Bug Importer 2011-08-16 08:06:28 PDT
<rdar://problem/9961042>
Comment 2 Eric Carlson 2011-08-16 08:45:32 PDT
Created attachment 104052 [details]
Proposed patch
Comment 3 Eric Carlson 2011-08-16 09:15:02 PDT
http://trac.webkit.org/changeset/93108
Comment 4 Tony Chang 2011-08-16 10:08:25 PDT
Did you mean to put the -iframe.html file in the resources subdirectory?  run-webkit-tests is treating it as a separate test.
Comment 5 Tony Chang 2011-08-16 10:08:33 PDT
I will try to fix.
Comment 6 Tony Chang 2011-08-16 10:16:50 PDT
http://trac.webkit.org/changeset/93123
Comment 7 Eric Carlson 2011-08-16 10:24:37 PDT
(In reply to comment #6)
> http://trac.webkit.org/changeset/93123

Thanks Tony!
Comment 8 Eric Carlson 2011-08-16 11:48:08 PDT
(In reply to comment #6)
> http://trac.webkit.org/changeset/93123

You shouldn't have had to create Chromium specific results - the test doesn't need to include the control location in the test results. I will fix this.
Comment 9 Eric Carlson 2011-08-16 13:14:34 PDT
http://trac.webkit.org/changeset/93148 should make the results platform independent.
Comment 10 Tony Chang 2011-08-16 13:36:32 PDT
(In reply to comment #9)
> http://trac.webkit.org/changeset/93148 should make the results platform independent.

Thanks!