RESOLVED FIXED66302
Apple's Windows port matches Lion for some test results, but doesn't use Lion results 
https://bugs.webkit.org/show_bug.cgi?id=66302
Summary Apple's Windows port matches Lion for some test results, but doesn't use Lion...
Adam Roben (:aroben)
Reported 2011-08-16 07:58:26 PDT
Apple's Windows port matches Lion for some test results, but doesn't use Lion results
Attachments
Patch (4.84 KB, patch)
2011-08-16 07:59 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Make Apple's Windows port fall back to Lion results instead of SnowLeopard (7.22 KB, patch)
2011-08-16 08:02 PDT, Adam Roben (:aroben) 		ddkilzer: review+
aroben: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-08-16 07:59:16 PDT
Created attachment 104042 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-08-16 08:02:40 PDT
Created attachment 104043 [details] Make Apple's Windows port fall back to Lion results instead of SnowLeopard
David Kilzer (:ddkilzer)
Comment 3 2011-08-16 08:10:24 PDT
Comment on attachment 104043 [details] Make Apple's Windows port fall back to Lion results instead of SnowLeopard View in context: https://bugs.webkit.org/attachment.cgi?id=104043&action=review r=me > Tools/Scripts/webkitpy/common/config/build_unittest.py:43 > + (["LayoutTests/platform/mac-lion/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]), Nit: I would have sub-ordered the mac-* ports by release: mac-leopard, mac-snowleopard, mac-lion, win
Adam Roben (:aroben)
Comment 4 2011-08-16 08:11:19 PDT
Comment on attachment 104043 [details] Make Apple's Windows port fall back to Lion results instead of SnowLeopard View in context: https://bugs.webkit.org/attachment.cgi?id=104043&action=review >> Tools/Scripts/webkitpy/common/config/build_unittest.py:43 >> + (["LayoutTests/platform/mac-lion/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]), > > Nit: I would have sub-ordered the mac-* ports by release: mac-leopard, mac-snowleopard, mac-lion, win Everything else is sorted lexicographically. I think we might as well maintain that here, too. Silly Apple for not naming releases alphabetically!
Adam Roben (:aroben)
Comment 5 2011-08-16 09:03:27 PDT
Committed r93107: <http://trac.webkit.org/changeset/93107>
Note You need to log in before you can comment on or make changes to this bug.