RESOLVED FIXED 66294
[WebSocket] Remove arguments from CloseEvent::create() 
https://bugs.webkit.org/show_bug.cgi?id=66294
Summary [WebSocket] Remove arguments from CloseEvent::create()
Takashi Toyoshima
Reported 2011-08-16 05:36:35 PDT
I took over implementation of CloseEvent's code and reason. For the coming next change, I'd like to remove arguments from CloseEvent::create() because it was useless.
Attachments
Patch (2.48 KB, patch)
2011-08-16 05:42 PDT, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Patch (2.71 KB, patch)
2011-08-17 02:27 PDT, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Patch (2.66 KB, patch)
2011-08-17 02:50 PDT, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2011-08-16 05:42:21 PDT
Created attachment 104030 [details] Patch
Yuta Kitamura
Comment 2 2011-08-16 05:56:49 PDT
Comment on attachment 104030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104030&action=review [Note: I'm not a WebKit reviewer] Code change looks fine to me. > Source/WebCore/ChangeLog:7 > + You need to write the reason why you can safely omit wasClean argument from create(). You also need to justify not adding a new test.
Takashi Toyoshima
Comment 3 2011-08-17 02:27:52 PDT
Created attachment 104159 [details] Patch
Yuta Kitamura
Comment 4 2011-08-17 02:42:30 PDT
Comment on attachment 104159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104159&action=review > Source/WebCore/ChangeLog:9 > + Remove arguments from CloseEvent::create(). CloseEvent objects are > + initialized by initCloseEvent() in all cases. Initialization in > + create() is redundant. We does not need additional tests because this > + change does not introduce any functional difference. > + https://bugs.webkit.org/show_bug.cgi?id=66294 > + > + Reviewed by NOBODY (OOPS!). Normally, ChangeLog entry is formatted like: <Bug title> <Bug URL> Reviewed by <Reviewer>. <Change description> See existing entries.
Takashi Toyoshima
Comment 5 2011-08-17 02:50:45 PDT
Created attachment 104163 [details] Patch
Takashi Toyoshima
Comment 6 2011-08-17 02:52:15 PDT
Sorry for bothering. Revised again.
Yuta Kitamura
Comment 7 2011-08-17 04:42:32 PDT
Comment on attachment 104163 [details] Patch Looks fine. [Note: I'm not a WebKit reviewer]
Kent Tamura
Comment 8 2011-08-17 23:44:21 PDT
Comment on attachment 104163 [details] Patch ok
WebKit Review Bot
Comment 9 2011-08-18 01:02:55 PDT
Comment on attachment 104163 [details] Patch Clearing flags on attachment: 104163 Committed r93288: <http://trac.webkit.org/changeset/93288>
WebKit Review Bot
Comment 10 2011-08-18 01:03:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.