I took over implementation of CloseEvent's code and reason. For the coming next change, I'd like to remove arguments from CloseEvent::create() because it was useless.
Created attachment 104030 [details] Patch
Comment on attachment 104030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104030&action=review [Note: I'm not a WebKit reviewer] Code change looks fine to me. > Source/WebCore/ChangeLog:7 > + You need to write the reason why you can safely omit wasClean argument from create(). You also need to justify not adding a new test.
Created attachment 104159 [details] Patch
Comment on attachment 104159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104159&action=review > Source/WebCore/ChangeLog:9 > + Remove arguments from CloseEvent::create(). CloseEvent objects are > + initialized by initCloseEvent() in all cases. Initialization in > + create() is redundant. We does not need additional tests because this > + change does not introduce any functional difference. > + https://bugs.webkit.org/show_bug.cgi?id=66294 > + > + Reviewed by NOBODY (OOPS!). Normally, ChangeLog entry is formatted like: <Bug title> <Bug URL> Reviewed by <Reviewer>. <Change description> See existing entries.
Created attachment 104163 [details] Patch
Sorry for bothering. Revised again.
Comment on attachment 104163 [details] Patch Looks fine. [Note: I'm not a WebKit reviewer]
Comment on attachment 104163 [details] Patch ok
Comment on attachment 104163 [details] Patch Clearing flags on attachment: 104163 Committed r93288: <http://trac.webkit.org/changeset/93288>
All reviewed patches have been landed. Closing bug.