Bug 66289 - Chromium: Do not store script source code in ScriptSourceCode instances for cached scripts
Summary: Chromium: Do not store script source code in ScriptSourceCode instances for c...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-16 04:04 PDT by Mikhail Naganov
Modified: 2011-08-16 11:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.35 KB, patch)
2011-08-16 06:03 PDT, Mikhail Naganov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-08-16 04:04:41 PDT 
Currently bindings/v8/ScriptSourceCode.h has m_source field which is populated using CachedScript. As a result, script source is stored twice. In JSC bindings, ScriptSourceCode extracts source from CachedScriptSourceProvider.
Comment 1 Mikhail Naganov 2011-08-16 06:03:18 PDT 
Created attachment 104031 [details]
Patch
Comment 2 Mikhail Naganov 2011-08-16 11:05:46 PDT 
Makes no sense, as String only holds a reference to a string from CachedScript.