Bug 66276 – "new WebKitCSSMatrix()" should generate a default matrix when undefined, null or an empty string is passed

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: DOM

[Kentaro Hara]

A Web IDL Constructor extended attribute should be implemented in V8 (bug 65839). We are going to split the patch for bug 65839 into the following eleven steps in order to avoid regressions. 

This patch is for [3]. Spec: http://www.w3.org/TR/css3-3d-transforms/  (Look at the setMatrixValue section)

[1] "new EventSource()" should throw SYNTAX_ERR when an invalid argument is passed.
[2] "new SharedWorker()" should throw SYNTAX_ERR when an invalid argument is passed.
[3] "new WebKitCSSMatrix()" should throw SYNTAX_ERR when an invalid argument is passed.
[4] "new Worker()" should throw SYNTAX_ERR when an invalid argument is passed.
[5] Implement the Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm.
[6] Replace the EventSource constructor in V8 with the Web IDL Constructor extended attribute.
[7] Replace the FileReader constructor in V8 with the Web IDL Constructor extended attribute.
[8] Replace the SharedWorker constructor in V8 with the Web IDL Constructor extended attribute.
[9] Replace the WebKitCSSMatrix constructor in V8 with the Web IDL Constructor extended attribute.
[10] Replace the Worker constructor in V8 with the Web IDL Constructor extended attribute.
[11] Replace the XSLTProcessor constructor in V8 with the Web IDL Constructor extended attribute.

Dependencies: [6][7][8][9][10][11] depends on [1][2][3][4][5]. We can land [1][2][3][4][5] concurrently, and then can land [6][7][8][9][10][11] concurrently.

[Kentaro Hara]

Created attachment 104024 [details]
Patch

[Alexey Proskuryakov]

Could you please explain why this change is correct in more detail? I suspect that it's not quite correct, for the same reason as in bug 66274.

[Kentaro Hara]

(In reply to comment #2)
> Could you please explain why this change is correct in more detail? I suspect that it's not quite correct, for the same reason as in bug 66274.

I am sorry. I confirmed that this is not a bug and thus should not be fixed.

[Alexey Proskuryakov]

Comment on attachment 104024 [details]
Patch

Marking r- per the above discussion.

[Kentaro Hara]

*** This bug has been marked as a duplicate of bug 67458 ***