The class is part of RenderObject currently which makes it difficult to change and could easily introduce cyclic or unwanted dependencies with RenderObject.
Created attachment 103968 [details] Proposed change: Move the code to a new class for easier hacking.
Comment on attachment 103968 [details] Proposed change: Move the code to a new class for easier hacking. View in context: https://bugs.webkit.org/attachment.cgi?id=103968&action=review LayoutRepainter.cpp should be RenderingAllInOne.cpp to make Windows build to pass. > Source/WebCore/rendering/RenderObject.h:117 > + friend class LayoutRepainter; Why do we need this?
Created attachment 105210 [details] Patch 2: Fixed windows build per Hajime's comment.
Comment on attachment 105210 [details] Patch 2: Fixed windows build per Hajime's comment. I'm sorry for the slow response.
Comment on attachment 105210 [details] Patch 2: Fixed windows build per Hajime's comment. Thanks Hajime!
Comment on attachment 105210 [details] Patch 2: Fixed windows build per Hajime's comment. Rejecting attachment 105210 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e-document-url.html = TEXT TIMEOUT PASS Regressions: Unexpected image and text mismatch : (1) svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT Regressions: Unexpected image mismatch : (5) fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE Full output: http://queues.webkit.org/results/9553008
Committed r94372: <http://trac.webkit.org/changeset/94372>