Bug 66254 – [CSSRegions] Make regions repaint properly.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Make sure regions do proper repainting when their content changes.

[Dave Hyatt]

Created attachment 103957 [details]
Work in progress (just need tests)

[Simon Fraser (smfr)]

Comment on attachment 103957 [details]
Work in progress (just need tests)

View in context: https://bugs.webkit.org/attachment.cgi?id=103957&action=review

> Source/WebCore/rendering/RenderView.h:251
>      bool m_pageLogicalHeightChanged;
>      LayoutState* m_layoutState;
>      unsigned m_layoutStateDisableCount;
> +    bool m_hasRenderFlowThreads;

Put this next to the other bools to reduce padding.

[Mihnea Ovidenie]

This will likely also fix https://bugs.webkit.org/show_bug.cgi?id=66199.

[Dave Hyatt]

Created attachment 104073 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 104073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104073&action=review

> Source/WebCore/rendering/RenderFlowThread.cpp:305
> +        // We only have to issue a repaint in this region if the region rect intersects the repaint rect.
> +        LayoutRect flippedRegionRect(region->regionRect());
> +        flipForWritingMode(flippedRegionRect); // Put the region rect into physical coordinates.

Can we assume that the rect will only intersect some contiguous set of regions? That might avoid having to iterate through all regions for each repaint, which is not terribly efficient.

> LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:1
> +layer at (0,0) size 800x600

Can the tests avoid the use of so much text, to reduce spurious pixel diffs?

[Dave Hyatt]

Fixed ages ago. Just forgot to close.