Bug 66250 – Switch RenderTextControl* to new layout types

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Levi Weintraub]

Ongoing conversion.

[Levi Weintraub]

Created attachment 103947 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 103947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103947&action=review

> Source/WebCore/rendering/LayoutTypes.h:97
> +inline LayoutUnit layoutMod(const LayoutUnit& numerator, const LayoutUnit& denominator)
> +{
> +    return numerator % denominator;
> +}

Otherwise the compiler gets sad about mis-matched types?

[Eric Seidel (no email)]

I'm confused that we need that layoutMod function, but I believe you.

[Levi Weintraub]

Comment on attachment 103947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103947&action=review

Thanks!

>> Source/WebCore/rendering/LayoutTypes.h:97
>> +}
> 
> Otherwise the compiler gets sad about mis-matched types?

% doesn't act as modulo for Float/Fixed types. This will be replaced with the proper equivalent for those :)

[WebKit Review Bot]

Comment on attachment 103947 [details]
Patch

Rejecting attachment 103947 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
ools/ChangeLog
CONFLICT (content): Merge conflict in Tools/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Source/WebCore: Crash in Document::recalcStyleSelector

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 146.

Full output: http://queues.webkit.org/results/9421093

[WebKit Review Bot]

Comment on attachment 103947 [details]
Patch

Rejecting attachment 103947 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
g Tools/ChangeLog
CONFLICT (content): Merge conflict in Tools/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Accessibility stack exhaustion using role attribute

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 146.

Full output: http://queues.webkit.org/results/9419269

[WebKit Review Bot]

Comment on attachment 103947 [details]
Patch

Clearing flags on attachment: 103947

Committed r93334: <http://trac.webkit.org/changeset/93334>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.