Bug 66246 - TransformState.move() should be negated in the unapply code path
Summary: TransformState.move() should be negated in the unapply code path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 67383
  Show dependency treegraph
 
Reported: 2011-08-15 12:37 PDT by Simon Fraser (smfr)
Modified: 2011-09-01 11:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.65 KB, patch)
2011-08-15 14:17 PDT, Simon Fraser (smfr)
cmarrin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-08-15 12:37:37 PDT
TransformState.move() should negate the arguments in the 'unapply' code path as it does for the 'apply' code path.
Comment 1 Simon Fraser (smfr) 2011-08-15 14:17:21 PDT
Created attachment 103950 [details]
Patch
Comment 2 Chris Marrin 2011-08-15 15:10:10 PDT
Comment on attachment 103950 [details]
Patch

r=me
Comment 3 Simon Fraser (smfr) 2011-08-31 18:19:30 PDT
http://trac.webkit.org/changeset/94259
Comment 4 Ryosuke Niwa 2011-09-01 00:33:04 PDT
This patch appears to have caused the following tests to fail on Qt bots:
fast/events/document-elementFromPoint.html
plugins/mouse-events-fixedpos.html

See http://build.webkit.org/builders/Qt%20Linux%20Release/builds/37020.
Comment 6 Simon Fraser (smfr) 2011-09-01 09:04:29 PDT
I already have bug 67353 and will look at these other tests today.
Comment 7 Simon Fraser (smfr) 2011-09-01 11:48:58 PDT
Tests fixed in http://trac.webkit.org/changeset/94324