Bug 66222 - [Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate()
Summary: [Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-08-15 06:12 PDT by Benjamin Poulain
Modified: 2011-08-15 12:07 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.44 KB, patch)
2011-08-15 06:19 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-08-15 06:12:14 PDT
As Kenneth pointed out, this method is evil because it breaks encapsulation and we have no control over who can access the private object.
Comment 1 Benjamin Poulain 2011-08-15 06:19:50 PDT
Created attachment 103910 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-15 12:07:14 PDT
Comment on attachment 103910 [details]
Patch

Clearing flags on attachment: 103910

Committed r93049: <http://trac.webkit.org/changeset/93049>
Comment 3 WebKit Review Bot 2011-08-15 12:07:18 PDT
All reviewed patches have been landed.  Closing bug.