RESOLVED FIXED 66215
Web Inspector: not all of the properties have valid descriptors on all platforms. Includes PropertyDescriptor protocol documentation fixes. 
https://bugs.webkit.org/show_bug.cgi?id=66215
Summary Web Inspector: not all of the properties have valid descriptors on all platfo...
Pavel Feldman
Reported 2011-08-15 02:09:45 PDT
A couple of fixes to the Inspector.json.
Attachments
Patch (7.00 KB, patch)
2011-08-15 02:48 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] With a test. (9.16 KB, patch)
2011-08-15 03:05 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-08-15 02:19:50 PDT
Activation in JSC, LocalStorage in V8 and some other properties potentially don't have valid property descriptors. InjectedScript should use conservative "for in" in order to close the gap.
Pavel Feldman
Comment 2 2011-08-15 02:48:07 PDT
Created attachment 103897 [details] Patch
Yury Semikhatsky
Comment 3 2011-08-15 02:50:27 PDT
Comment on attachment 103897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103897&action=review > Source/WebCore/inspector/InjectedScriptSource.js:227 > + descriptors.push({ name: name, value: object[name], writable: false, configurable: false, enumerable: true}); Can you add a test for this?
Pavel Feldman
Comment 4 2011-08-15 03:05:23 PDT
Created attachment 103898 [details] [PATCH] With a test.
Pavel Feldman
Comment 5 2011-08-15 03:27:14 PDT
Committed r93037: <http://trac.webkit.org/changeset/93037>
Note You need to log in before you can comment on or make changes to this bug.