Bug 66206 - [chromium] Implement shouldRubberBandInDirection
Summary: [chromium] Implement shouldRubberBandInDirection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-14 09:45 PDT by Nico Weber
Modified: 2011-08-15 12:59 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.02 KB, patch)
2011-08-14 09:48 PDT, Nico Weber
no flags Details | Formatted Diff | Diff
Patch (3.02 KB, patch)
2011-08-14 13:28 PDT, Nico Weber
no flags Details | Formatted Diff | Diff
Patch (3.02 KB, patch)
2011-08-15 10:39 PDT, Nico Weber
no flags Details | Formatted Diff | Diff
Patch for landing (3.02 KB, patch)
2011-08-15 10:47 PDT, Nico Weber
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-08-14 09:45:40 PDT
[chromium] Implement shouldRubberBandInDirection
Comment 1 Nico Weber 2011-08-14 09:48:54 PDT
Created attachment 103881 [details]
Patch
Comment 2 Nico Weber 2011-08-14 13:28:32 PDT
Created attachment 103882 [details]
Patch
Comment 3 Nico Weber 2011-08-15 10:09:47 PDT
This goes with http://codereview.chromium.org/7618036/
Comment 4 Adam Barth 2011-08-15 10:32:29 PDT
Comment on attachment 103882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103882&action=review

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:977
> +      return false;

bad indent
Comment 5 Adam Barth 2011-08-15 10:33:00 PDT
Comment on attachment 103882 [details]
Patch

Can we test this sort of change?
Comment 6 Nico Weber 2011-08-15 10:39:34 PDT
Created attachment 103924 [details]
Patch
Comment 7 Nico Weber 2011-08-15 10:40:57 PDT
Comment on attachment 103924 [details]
Patch

Thanks, I'll look into writing a test for this in.
Comment 8 Nico Weber 2011-08-15 10:43:35 PDT
Looks like writing tests for this is blocked on issue 11042 and on eventSender growing support for gesture events.
Comment 9 Nico Weber 2011-08-15 10:47:08 PDT
Created attachment 103926 [details]
Patch for landing
Comment 10 WebKit Review Bot 2011-08-15 12:59:23 PDT
Comment on attachment 103926 [details]
Patch for landing

Clearing flags on attachment: 103926

Committed r93056: <http://trac.webkit.org/changeset/93056>
Comment 11 WebKit Review Bot 2011-08-15 12:59:27 PDT
All reviewed patches have been landed.  Closing bug.