Bug 66200 - Switch results detail view over to new-style object-oriented UI widgets
Summary: Switch results detail view over to new-style object-oriented UI widgets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 64188
  Show dependency treegraph
 
Reported: 2011-08-13 19:22 PDT by Adam Barth
Modified: 2011-08-14 00:02 PDT (History)
0 users

See Also:


Attachments
Patch (14.56 KB, patch)
2011-08-13 19:26 PDT, Adam Barth
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-13 19:22:17 PDT
Switch results detail view over to new-style object-oriented UI widgets
Comment 1 Adam Barth 2011-08-13 19:26:19 PDT
Created attachment 103870 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-08-13 20:32:08 PDT
Comment on attachment 103870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103870&action=review

Cool! I am happy you like extensible DOM objects :)

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:62
> +<script src="ui/results.js"></script>

I was wondering if we could put scripts in scripts/ directory: scripts/ui/results.js.

Similarly styles would go to styles/, and images to images/.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:101
> +        var self = this;  // I bet dglazkov knows how to avoid this ickiness.

you can add use Function.bind(this) --> function(...) {  ... }.bind(this) in decl.
Comment 3 Adam Barth 2011-08-13 21:25:25 PDT
(In reply to comment #2)
> (From update of attachment 103870 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103870&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:62
> > +<script src="ui/results.js"></script>
> 
> I was wondering if we could put scripts in scripts/ directory: scripts/ui/results.js.
> 
> Similarly styles would go to styles/, and images to images/.

I can take care of that when you don't have any outstanding patches (to avoid merge conflicts).

I'm slightly sad that we're loading so many separate script files.  It's probably not important at all for this project but I wish we could get it down to a single request.
Comment 4 Adam Barth 2011-08-14 00:02:53 PDT
Committed r93029: <http://trac.webkit.org/changeset/93029>