Bug 66200 – Switch results detail view over to new-style object-oriented UI widgets

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Switch results detail view over to new-style object-oriented UI widgets

[Adam Barth]

Created attachment 103870 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 103870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103870&action=review

Cool! I am happy you like extensible DOM objects :)

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:62
> +<script src="ui/results.js"></script>

I was wondering if we could put scripts in scripts/ directory: scripts/ui/results.js.

Similarly styles would go to styles/, and images to images/.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:101
> +        var self = this;  // I bet dglazkov knows how to avoid this ickiness.

you can add use Function.bind(this) --> function(...) {  ... }.bind(this) in decl.

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 103870 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103870&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:62
> > +<script src="ui/results.js"></script>
> 
> I was wondering if we could put scripts in scripts/ directory: scripts/ui/results.js.
> 
> Similarly styles would go to styles/, and images to images/.

I can take care of that when you don't have any outstanding patches (to avoid merge conflicts).

I'm slightly sad that we're loading so many separate script files.  It's probably not important at all for this project but I wish we could get it down to a single request.

[Adam Barth]

Committed r93029: <http://trac.webkit.org/changeset/93029>