Bug 66191 - Fix incorrect objective-c initialize in WebCore
Summary: Fix incorrect objective-c initialize in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-13 11:34 PDT by Sam Weinig
Modified: 2011-08-13 11:51 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2011-08-13 11:35 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (1.83 KB, patch)
2011-08-13 11:42 PDT, Sam Weinig
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-08-13 11:34:41 PDT
Fix incorrect objective-c initialize in WebCore
Comment 1 Sam Weinig 2011-08-13 11:35:40 PDT
Created attachment 103863 [details]
Patch
Comment 2 mitz 2011-08-13 11:39:09 PDT
Comment on attachment 103863 [details]
Patch

!
Comment 3 Sam Weinig 2011-08-13 11:40:53 PDT
Eek! I am so ashamed :(
Comment 4 Sam Weinig 2011-08-13 11:42:44 PDT
Created attachment 103864 [details]
Patch
Comment 5 David Kilzer (:ddkilzer) 2011-08-13 11:45:56 PDT
Comment on attachment 103864 [details]
Patch

r=me

It's more straightforward if you do this anyway:

self = [super init];
if (!self)
    return nil;
Comment 6 Sam Weinig 2011-08-13 11:51:10 PDT
Committed r93021: <http://trac.webkit.org/changeset/93021>