RESOLVED FIXED 66175
Add shell implementation for Web Audio API's MediaElementAudioSourceNode 
https://bugs.webkit.org/show_bug.cgi?id=66175
Summary Add shell implementation for Web Audio API's MediaElementAudioSourceNode
Chris Rogers
Reported 2011-08-12 15:51:45 PDT
Add shell implementation for Web Audio API's MediaElementAudioSourceNode
Attachments
Patch (17.71 KB, patch)
2011-08-12 16:01 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (26.71 KB, patch)
2011-08-12 18:46 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-08-12 16:01:17 PDT
Created attachment 103836 [details] Patch
Kenneth Russell
Comment 2 2011-08-12 16:19:55 PDT
Comment on attachment 103836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103836&action=review Looks good to me. Is the WebKit Mac port compiling in the WebAudio stuff? If so, the Xcode project should be updated as well. > Source/WebCore/webaudio/MediaElementAudioSourceNode.h:38 > + static PassRefPtr<MediaElementAudioSourceNode> create(AudioContext*, HTMLMediaElement*); Conceptually is there any layering violation here? I suspect not because the webaudio/ classes are all accessible from JavaScript, so they are more or less at parity with other classes in Source/WebCore/html/; but this is the first reference from the webaudio/ classes to html/ classes.
Chris Rogers
Comment 3 2011-08-12 18:46:32 PDT
Created attachment 103852 [details] Patch
Chris Rogers
Comment 4 2011-08-12 18:47:56 PDT
latest patch updates the Xcode project for building on the mac port
Kenneth Russell
Comment 5 2011-08-15 10:16:43 PDT
Comment on attachment 103852 [details] Patch OK, looks good.
WebKit Review Bot
Comment 6 2011-08-15 12:37:37 PDT
Comment on attachment 103852 [details] Patch Clearing flags on attachment: 103852 Committed r93054: <http://trac.webkit.org/changeset/93054>
WebKit Review Bot
Comment 7 2011-08-15 12:37:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.