Add shell implementation for Web Audio API's MediaElementAudioSourceNode
Created attachment 103836 [details] Patch
Comment on attachment 103836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103836&action=review Looks good to me. Is the WebKit Mac port compiling in the WebAudio stuff? If so, the Xcode project should be updated as well. > Source/WebCore/webaudio/MediaElementAudioSourceNode.h:38 > + static PassRefPtr<MediaElementAudioSourceNode> create(AudioContext*, HTMLMediaElement*); Conceptually is there any layering violation here? I suspect not because the webaudio/ classes are all accessible from JavaScript, so they are more or less at parity with other classes in Source/WebCore/html/; but this is the first reference from the webaudio/ classes to html/ classes.
Created attachment 103852 [details] Patch
latest patch updates the Xcode project for building on the mac port
Comment on attachment 103852 [details] Patch OK, looks good.
Comment on attachment 103852 [details] Patch Clearing flags on attachment: 103852 Committed r93054: <http://trac.webkit.org/changeset/93054>
All reviewed patches have been landed. Closing bug.