Bug 66175 - Add shell implementation for Web Audio API's MediaElementAudioSourceNode
Summary: Add shell implementation for Web Audio API's MediaElementAudioSourceNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-12 15:51 PDT by Chris Rogers
Modified: 2011-08-15 12:37 PDT (History)
2 users (show)

See Also:


Attachments
Patch (17.71 KB, patch)
2011-08-12 16:01 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (26.71 KB, patch)
2011-08-12 18:46 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-08-12 15:51:45 PDT
Add shell implementation for Web Audio API's MediaElementAudioSourceNode
Comment 1 Chris Rogers 2011-08-12 16:01:17 PDT
Created attachment 103836 [details]
Patch
Comment 2 Kenneth Russell 2011-08-12 16:19:55 PDT
Comment on attachment 103836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103836&action=review

Looks good to me. Is the WebKit Mac port compiling in the WebAudio stuff? If so, the Xcode project should be updated as well.

> Source/WebCore/webaudio/MediaElementAudioSourceNode.h:38
> +    static PassRefPtr<MediaElementAudioSourceNode> create(AudioContext*, HTMLMediaElement*);

Conceptually is there any layering violation here? I suspect not because the webaudio/ classes are all accessible from JavaScript, so they are more or less at parity with other classes in Source/WebCore/html/; but this is the first reference from the webaudio/ classes to html/ classes.
Comment 3 Chris Rogers 2011-08-12 18:46:32 PDT
Created attachment 103852 [details]
Patch
Comment 4 Chris Rogers 2011-08-12 18:47:56 PDT
latest patch updates the Xcode project for building on the mac port
Comment 5 Kenneth Russell 2011-08-15 10:16:43 PDT
Comment on attachment 103852 [details]
Patch

OK, looks good.
Comment 6 WebKit Review Bot 2011-08-15 12:37:37 PDT
Comment on attachment 103852 [details]
Patch

Clearing flags on attachment: 103852

Committed r93054: <http://trac.webkit.org/changeset/93054>
Comment 7 WebKit Review Bot 2011-08-15 12:37:41 PDT
All reviewed patches have been landed.  Closing bug.