WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
66166
garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
https://bugs.webkit.org/show_bug.cgi?id=66166
Summary
garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
Dimitri Glazkov (Google)
Reported
2011-08-12 14:17:48 PDT
garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
Attachments
Patch
(3.19 KB, patch)
2011-08-12 14:18 PDT
,
Dimitri Glazkov (Google)
no flags
Details
Formatted Diff
Diff
Patch
(5.81 KB, patch)
2011-08-12 15:49 PDT
,
Dimitri Glazkov (Google)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2011-08-12 14:18:33 PDT
Created
attachment 103814
[details]
Patch
Adam Barth
Comment 2
2011-08-12 14:31:55 PDT
Comment on
attachment 103814
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=103814&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:292 > + model.analyzeUnexpectedFailures(showUnexpectedFailure, function() { > + dismissButterbar(); > + });
You can just pass dismissButterbar as the completion callback. You don't need the thunk.
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:126 > + var queriesInFlight = Object.keys(unexpectedFailures).length;
please use base.RequestTracker.
Dimitri Glazkov (Google)
Comment 3
2011-08-12 15:49:01 PDT
Created
attachment 103833
[details]
Patch
Adam Barth
Comment 4
2011-08-12 15:53:11 PDT
Comment on
attachment 103833
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=103833&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:114 > + this._tryCallback();
Did you check the other call sites to see what they thought of this new behavior? I seem to remember a bunch of them doing this manually.
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:117 > +base.RequestTracker.prototype = {
I prefer the other style of modifying the prototype, but whatever.
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:126 > + var tracker = new base.RequestTracker(Object.keys(unexpectedFailures).length, completionCallback);
Why Object.keys and not base.keys ? Should base.keys == Object.keys when Object.keys is available?
Dimitri Glazkov (Google)
Comment 5
2011-08-12 15:59:02 PDT
Comment on
attachment 103833
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=103833&action=review
>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:114 >> + this._tryCallback(); > > Did you check the other call sites to see what they thought of this new behavior? I seem to remember a bunch of them doing this manually.
Yep. I did. There were only two other callsites.
>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:117 >> +base.RequestTracker.prototype = { > > I prefer the other style of modifying the prototype, but whatever.
:)
Dimitri Glazkov (Google)
Comment 6
2011-08-13 08:39:17 PDT
Comment on
attachment 103833
[details]
Patch Clearing flags on attachment: 103833 Committed
r93016
: <
http://trac.webkit.org/changeset/93016
>
Dimitri Glazkov (Google)
Comment 7
2011-08-13 08:39:22 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug