Bug 66165 - FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
: FrameLoaderClient::transferLoadingResourceFromPage does not have enough param...
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 66163
  Show dependency treegraph
 
Reported: 2011-08-12 14:04 PST by
Modified: 2011-08-15 15:49 PST (History)


Attachments
Patch (37.67 KB, patch)
2011-08-12 14:26 PST, Dmitry Titov
gns: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Fixed Gtk build error. (37.66 KB, patch)
2011-08-12 15:46 PST, Dmitry Titov
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Fixed Mac build error (38.84 KB, patch)
2011-08-15 11:49 PST, Dmitry Titov
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-08-12 14:04:28 PST
Existing FrameLoaderClient::transferLoadingResourceFromPage notification is not very useful because it comes with DocumentLoader, and in case of subresources does not give enough information to the embedder to redirect the network notifications properly.

The solution is to pass ResourceLoader of each loading resource into this notification. ResourceLoader wraps all the information about current load, including embedder- and platform- specific (via ResourceHandle) which should give the embedder all the info it needs to associate the ongoing load requests with the new top-level WebFrame/WebView objects.
------- Comment #1 From 2011-08-12 14:26:10 PST -------
Created an attachment (id=103816) [details]
Patch

The patch changes signature of FrameLoaderClient method from:
        virtual void transferLoadingResourceFromPage(unsigned long identifier, DocumentLoader*, const ResourceRequest&, Page* oldPage) = 0;
to:
        virtual void transferLoadingResourceFromPage(ResourceLoader*, const ResourceRequest&, Page* oldPage) = 0;

The old parameters 'identifier' and 'documentLoader' are accessible from ResourceLoader

Also fixed a bug when this notification was invoked in DocumentLoader with the same ResourceRequest for all subresources.
------- Comment #2 From 2011-08-12 14:32:10 PST -------
To my memory Adam and Nate have done many changes in this area.

btw, no r? yet.
------- Comment #3 From 2011-08-12 15:39:09 PST -------
(From update of attachment 103816 [details])
Attachment 103816 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9378024
------- Comment #4 From 2011-08-12 15:46:14 PST -------
Created an attachment (id=103831) [details]
Fixed Gtk build error.
------- Comment #5 From 2011-08-12 18:27:47 PST -------
(From update of attachment 103831 [details])
Attachment 103831 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9378071
------- Comment #6 From 2011-08-15 11:49:25 PST -------
Created an attachment (id=103937) [details]
Fixed Mac build error
------- Comment #7 From 2011-08-15 15:49:50 PST -------
(From update of attachment 103937 [details])
Clearing flags on attachment: 103937

Committed r93066: <http://trac.webkit.org/changeset/93066>
------- Comment #8 From 2011-08-15 15:49:55 PST -------
All reviewed patches have been landed.  Closing bug.