RESOLVED FIXED 66160
DFG JIT has inconsistent use of boxDouble and unboxDouble, inconsistent use of assertions regarding doubles, and those assertions are not turned on in debug builds 
https://bugs.webkit.org/show_bug.cgi?id=66160
Summary DFG JIT has inconsistent use of boxDouble and unboxDouble, inconsistent use o...
Filip Pizlo
Reported 2011-08-12 13:39:21 PDT
The DFG JIT has helper methods for boxing and unboxing doubles, but they are not always used, leading to code duplication. The DFG JIT has a way of emitting assertions that something that it thinks is a boxed double is in fact a bosed double, and it uses those assertions in one place (where the code for unboxDouble is duplicated, no less) but not in others. Furthermore, the JIT assertions (assertions emitted in the code stream) are not enabled in debug builds by default, which greatly reduces their utility. The DFG JIT should enable JIT assertions in debug builds, should use existing assertions (such as AssertIsJSDouble) during boxing and unboxing, and should not duplicate the code for boxing and unboxing.
Attachments
the patch (9.30 KB, patch)
2011-08-12 13:43 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-08-12 13:43:38 PDT
Created attachment 103808 [details] the patch
WebKit Review Bot
Comment 2 2011-08-12 16:28:00 PDT
Comment on attachment 103808 [details] the patch Clearing flags on attachment: 103808 Committed r93010: <http://trac.webkit.org/changeset/93010>
WebKit Review Bot
Comment 3 2011-08-12 16:28:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.