Bug 66156 – Switch RenderBox to to new layout types

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Convert *** to new layout abstraction as a part of the ongoing conversion work.

[Emil A Eklund]

Created attachment 103844 [details]
Patch

[WebKit Review Bot]

Comment on attachment 103844 [details]
Patch

Attachment 103844 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9378061

New failing tests:
fast/block/float/overhanging-tall-block.html

[Emil A Eklund]

The test overhanging-tall-block.html seems to be missing expected results for cr-linux.

Will investigate before I submit but please go ahead and review.

[Emil A Eklund]

Actually, the output suggests that the failing test is the following rather than the float test.

Regressions: Unexpected image and text mismatch : (1)
  svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT

Looking into why now.

[Emil A Eklund]

Created attachment 103851 [details]
Patch

[Emil A Eklund]

Created attachment 103984 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 103984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103984&action=review

> Source/WebCore/rendering/RenderBox.cpp:1151
> +    LayoutRect clipRect(location + LayoutSize(borderLeft(), borderTop()),

Isn't this borderRect().location?

> Source/WebCore/rendering/RenderBox.cpp:1864
> -            logicalHeight = h.value();
> +            logicalHeight = h.calcFloatValue(0);

Why?

[Emil A Eklund]

(In reply to comment #7)
> (From update of attachment 103984 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103984&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:1151
> > +    LayoutRect clipRect(location + LayoutSize(borderLeft(), borderTop()),
> 
> Isn't this borderRect().location?

No, borderBoxRect.location is in the local coordinate space (i.e. does not include the location offset).

> 
> > Source/WebCore/rendering/RenderBox.cpp:1864
> > -            logicalHeight = h.value();
> > +            logicalHeight = h.calcFloatValue(0);
> 
> Why?

Good catch, reverted.

[Emil A Eklund]

Created attachment 104227 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 104227 [details]
Patch for landing

Rejecting attachment 104227 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
.
creating empty directory: LayoutTests/platform/chromium-mac-leopard
creating empty directory: LayoutTests/platform/chromium-mac/fast/events
creating empty directory: LayoutTests/platform/chromium-mac/http/tests/workers
creating empty directory: LayoutTests/platform/chromium-mac/storage/domstorage
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9423376

[WebKit Review Bot]

Comment on attachment 104227 [details]
Patch for landing

Clearing flags on attachment: 104227

Committed r93284: <http://trac.webkit.org/changeset/93284>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.