Bug 66146 - Switch RenderTable* to new layout types
Summary: Switch RenderTable* to new layout types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency treegraph
 
Reported: 2011-08-12 10:45 PDT by Levi Weintraub
Modified: 2011-08-12 14:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (23.37 KB, patch)
2011-08-12 10:51 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch for landing (67.61 KB, patch)
2011-08-12 13:14 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-08-12 10:45:48 PDT
Ongoing conversion.
Comment 1 Levi Weintraub 2011-08-12 10:51:58 PDT
Created attachment 103781 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-08-12 12:04:03 PDT
Comment on attachment 103781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103781&action=review

> Source/WebCore/rendering/RenderTableRow.cpp:186
> +    return LayoutRect();

This function still returns an IntRect, though no?

> Source/WebCore/rendering/RenderTableSection.cpp:318
> +        LayoutUnit bdesc = 0;
> +        LayoutUnit ch = m_grid[r].logicalHeight.calcMinValue(0);

Such helpful variable names!

> Source/WebCore/rendering/RenderTableSection.cpp:342
> -                    statePusher.push(this, IntSize(x(), y()));
> +                    statePusher.push(this, LayoutSize(x(), y()));

I'm surprised there isn't already a location() which could be converted to a point directly.

> Source/WebCore/rendering/RenderTableSection.cpp:432
> +        LayoutUnit dh = toAdd;

Oh goodie!  dh!  Of course. :)

> Source/WebCore/rendering/RenderTableSection.cpp:571
> +                    LayoutUnit b = cell->cellBaselinePosition();

b, yes-sir.  b it is!

> Source/WebCore/rendering/RenderTableSection.cpp:617
> +            view()->addLayoutDelta(LayoutSize(oldCellRect.x() - cell->x(), oldCellRect.y() - cell->y()));

rect.location - rect.location?

> Source/WebCore/rendering/RenderTableSection.cpp:631
> +            LayoutSize childOffset(cell->x() - oldCellRect.x(), cell->y() - oldCellRect.y());

cell->location() - oldcellRect.location()?
Comment 3 Levi Weintraub 2011-08-12 12:57:22 PDT
Thanks for the review! I'm fixing the things you mentioned and landing :)
Comment 4 Levi Weintraub 2011-08-12 13:14:40 PDT
Created attachment 103805 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-08-12 14:02:00 PDT
Comment on attachment 103805 [details]
Patch for landing

Clearing flags on attachment: 103805

Committed r92992: <http://trac.webkit.org/changeset/92992>
Comment 6 WebKit Review Bot 2011-08-12 14:02:04 PDT
All reviewed patches have been landed.  Closing bug.