Ongoing conversion.
Created attachment 103781 [details] Patch
Comment on attachment 103781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103781&action=review > Source/WebCore/rendering/RenderTableRow.cpp:186 > + return LayoutRect(); This function still returns an IntRect, though no? > Source/WebCore/rendering/RenderTableSection.cpp:318 > + LayoutUnit bdesc = 0; > + LayoutUnit ch = m_grid[r].logicalHeight.calcMinValue(0); Such helpful variable names! > Source/WebCore/rendering/RenderTableSection.cpp:342 > - statePusher.push(this, IntSize(x(), y())); > + statePusher.push(this, LayoutSize(x(), y())); I'm surprised there isn't already a location() which could be converted to a point directly. > Source/WebCore/rendering/RenderTableSection.cpp:432 > + LayoutUnit dh = toAdd; Oh goodie! dh! Of course. :) > Source/WebCore/rendering/RenderTableSection.cpp:571 > + LayoutUnit b = cell->cellBaselinePosition(); b, yes-sir. b it is! > Source/WebCore/rendering/RenderTableSection.cpp:617 > + view()->addLayoutDelta(LayoutSize(oldCellRect.x() - cell->x(), oldCellRect.y() - cell->y())); rect.location - rect.location? > Source/WebCore/rendering/RenderTableSection.cpp:631 > + LayoutSize childOffset(cell->x() - oldCellRect.x(), cell->y() - oldCellRect.y()); cell->location() - oldcellRect.location()?
Thanks for the review! I'm fixing the things you mentioned and landing :)
Created attachment 103805 [details] Patch for landing
Comment on attachment 103805 [details] Patch for landing Clearing flags on attachment: 103805 Committed r92992: <http://trac.webkit.org/changeset/92992>
All reviewed patches have been landed. Closing bug.