Bug 66134 – Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alexander Færøy]

Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage, as used by the Qt port.

Instead use FrameView's corresponding functions. Caching fixed layout size information on both WebCore::FrameView and WebKit::WebPage can lead to syncing problems on WebKit2.

resizesToContents is currently only being used in the Qt port.

[Alexander Færøy]

Created attachment 103763 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 103763 [details]
Patch

Attachment 103763 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9358617

[Collabora GTK+ EWS bot]

Comment on attachment 103763 [details]
Patch

Attachment 103763 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9357626

[Hajime Morrita]

Comment on attachment 103763 [details]
Patch

Please fix the build error anyway.

[Kenneth Rohde Christiansen]

Comment on attachment 103763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103763&action=review

> Source/WebCore/page/Frame.cpp:911
> -        frameView->setUseFixedLayout(useFixedLayout);
> +        frameView->setUseFixedLayout(!fixedLayoutSize.isEmpty());

So how do you turn it on the first time?  I mean the view is created before we get the layout size (viewport meta tag)

> Source/WebKit2/ChangeLog:1
> [phone]  Alexander Færøy  <[e-mail]>

Something is up with your name!

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:668
> +    // FIXME: ??? frame->view()->forceLayout();

What do you mean with that? You set needslayout below

[Kenneth Rohde Christiansen]

Created attachment 111000 [details]
Patch

[Simon Hausmann]

Comment on attachment 111000 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 111000 [details]
Patch

Clearing flags on attachment: 111000

Committed r97462: <http://trac.webkit.org/changeset/97462>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

You guys broke the SL build:

/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: In member function 'virtual void WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage()':
/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1116: warning: unused variable 'view'

Reopen to fix it.

[Csaba Osztrogonác]

Fix landed: http://trac.webkit.org/changeset/97465