Bug 66134 - Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage
Summary: Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-12 05:03 PDT by Alexander Færøy
Modified: 2011-10-14 08:34 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.50 KB, patch)
2011-08-12 05:28 PDT, Alexander Færøy
morrita: review-
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (7.35 KB, patch)
2011-10-14 05:36 PDT, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Færøy 2011-08-12 05:03:20 PDT
Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage, as used by the Qt port.

Instead use FrameView's corresponding functions. Caching fixed layout size information on both WebCore::FrameView and WebKit::WebPage can lead to syncing problems on WebKit2.

resizesToContents is currently only being used in the Qt port.
Comment 1 Alexander Færøy 2011-08-12 05:28:35 PDT
Created attachment 103763 [details]
Patch
Comment 2 Gyuyoung Kim 2011-08-12 05:38:37 PDT
Comment on attachment 103763 [details]
Patch

Attachment 103763 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9358617
Comment 3 Collabora GTK+ EWS bot 2011-08-12 05:38:41 PDT
Comment on attachment 103763 [details]
Patch

Attachment 103763 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9357626
Comment 4 Hajime Morrita 2011-08-15 21:03:07 PDT
Comment on attachment 103763 [details]
Patch

Please fix the build error anyway.
Comment 5 Kenneth Rohde Christiansen 2011-08-17 14:44:23 PDT
Comment on attachment 103763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103763&action=review

> Source/WebCore/page/Frame.cpp:911
> -        frameView->setUseFixedLayout(useFixedLayout);
> +        frameView->setUseFixedLayout(!fixedLayoutSize.isEmpty());

So how do you turn it on the first time?  I mean the view is created before we get the layout size (viewport meta tag)

> Source/WebKit2/ChangeLog:1
> +2011-08-12  Alexander Færøy  <alexander.faeroy@nokia.com>

Something is up with your name!

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:668
> +    // FIXME: ??? frame->view()->forceLayout();

What do you mean with that? You set needslayout below
Comment 6 Kenneth Rohde Christiansen 2011-10-14 05:36:57 PDT
Created attachment 111000 [details]
Patch
Comment 7 Simon Hausmann 2011-10-14 06:00:36 PDT
Comment on attachment 111000 [details]
Patch

r=me
Comment 8 WebKit Review Bot 2011-10-14 07:08:51 PDT
Comment on attachment 111000 [details]
Patch

Clearing flags on attachment: 111000

Committed r97462: <http://trac.webkit.org/changeset/97462>
Comment 9 WebKit Review Bot 2011-10-14 07:08:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Csaba Osztrogonác 2011-10-14 07:25:27 PDT
You guys broke the SL build:

/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: In member function 'virtual void WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage()':
/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1116: warning: unused variable 'view'

Reopen to fix it.
Comment 11 Csaba Osztrogonác 2011-10-14 08:34:38 PDT
Fix landed: http://trac.webkit.org/changeset/97465