Bug 66126 - Implement animation and transition properties in CSSStyleApplyProperty.
Summary: Implement animation and transition properties in CSSStyleApplyProperty.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks: 66118
  Show dependency tree / graph
 
Reported: 2011-08-11 22:25 PDT by Luke Macpherson
Modified: 2011-08-25 18:32 PDT (History)
6 users (show)

See Also:

Attachments
Patch (20.69 KB, patch)
2011-08-11 22:30 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (21.17 KB, patch)
2011-08-14 17:37 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (21.17 KB, patch)
2011-08-14 18:10 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-08-11 22:25:33 PDT 
Implement animation and transition properties in CSSStyleApplyProperty.
Comment 1 Luke Macpherson 2011-08-11 22:30:26 PDT 
Created attachment 103737 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-12 00:53:57 PDT 
Comment on attachment 103737 [details]
Patch

Attachment 103737 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9352481
Comment 3 WebKit Review Bot 2011-08-12 01:15:08 PDT 
Comment on attachment 103737 [details]
Patch

Attachment 103737 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9358546
Comment 4 Luke Macpherson 2011-08-14 17:37:31 PDT 
Created attachment 103886 [details]
Patch
Comment 5 WebKit Review Bot 2011-08-14 17:40:11 PDT 
Attachment 103886 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/animation/Animation.cpp:133:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Luke Macpherson 2011-08-14 18:10:44 PDT 
Created attachment 103887 [details]
Patch
Comment 7 Luke Macpherson 2011-08-21 22:41:56 PDT 
One-week ping! Could someone please review this?
Comment 8 Dean Jackson 2011-08-24 18:59:12 PDT 
I'd like to review this. See my comments in 66118.

I should get to the review later today or tomorrow.
Comment 9 Luke Macpherson 2011-08-24 19:01:02 PDT 
Thanks Dean. I had actually forgotten about the other bug :)
Comment 10 WebKit Review Bot 2011-08-25 18:32:33 PDT 
Comment on attachment 103887 [details]
Patch

Clearing flags on attachment: 103887

Committed r93848: <http://trac.webkit.org/changeset/93848>
Comment 11 WebKit Review Bot 2011-08-25 18:32:37 PDT 
All reviewed patches have been landed.  Closing bug.